From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12719 invoked from network); 20 Sep 2004 13:10:59 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 20 Sep 2004 13:10:59 -0000 Received: (qmail 92472 invoked from network); 20 Sep 2004 13:10:52 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 20 Sep 2004 13:10:52 -0000 Received: (qmail 26359 invoked by alias); 20 Sep 2004 13:10:39 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20391 Received: (qmail 26345 invoked from network); 20 Sep 2004 13:10:38 -0000 Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 20 Sep 2004 13:10:38 -0000 Received: (qmail 91841 invoked from network); 20 Sep 2004 13:09:39 -0000 Received: from lhuumrelay3.lnd.ops.eu.uu.net (62.189.58.19) by a.mx.sunsite.dk with SMTP; 20 Sep 2004 13:09:37 -0000 Received: from MAILSWEEPER01.csr.com (mailhost1.csr.com [62.189.183.235]) by lhuumrelay3.lnd.ops.eu.uu.net (8.11.0/8.11.0) with ESMTP id i8KD9Xv28278 for ; Mon, 20 Sep 2004 13:09:34 GMT Received: from EXCHANGE02.csr.com (unverified [192.168.137.45]) by MAILSWEEPER01.csr.com (Content Technologies SMTPRS 4.3.12) with ESMTP id for ; Mon, 20 Sep 2004 14:08:33 +0100 Received: from news01.csr.com ([192.168.143.38]) by EXCHANGE02.csr.com with Microsoft SMTPSVC(5.0.2195.6713); Mon, 20 Sep 2004 14:10:58 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.12.11/8.12.11) with ESMTP id i8KD9SZi007200 for ; Mon, 20 Sep 2004 14:09:28 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.12.11/8.12.11/Submit) with ESMTP id i8KD9QuP007197 for ; Mon, 20 Sep 2004 14:09:28 +0100 Message-Id: <200409201309.i8KD9QuP007197@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk (Zsh hackers list) Subject: PATCH: SHLVL not updated in environment Date: Mon, 20 Sep 2004 14:09:26 +0100 From: Peter Stephenson X-OriginalArrivalTime: 20 Sep 2004 13:10:58.0677 (UTC) FILETIME=[4529AA50:01C49F13] X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=0.0 required=6.0 tests=none autolearn=no version=2.63 X-Spam-Hits: 0.0 % zsh % print $SHLVL 3 % printenv SHLVL 2 This is a bug, right? I'm not missing some extreme sublety? Is this the right fix, rather than reversing the sense of the test? It seems that SHLVL has to be exported for it to work, although the documentation doesn't explicitly indicate it always will be exported. ((SHLVL++, SHLVL--)) is a workaround. Index: Src/params.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/params.c,v retrieving revision 1.89 diff -u -r1.89 params.c --- Src/params.c 17 Sep 2004 09:25:42 -0000 1.89 +++ Src/params.c 20 Sep 2004 13:05:20 -0000 @@ -594,8 +594,8 @@ addenv(pm, pm->u.str); pm = (Param) paramtab->getnode(paramtab, "SHLVL"); sprintf(buf, "%d", (int)++shlvl); - if (!(pm->flags & PM_EXPORTED)) - addenv(pm, buf); + /* shlvl value in environment needs updating unconditionally */ + addenv(pm, buf); /* Add the standard non-special parameters */ set_pwd_env(); -- Peter Stephenson Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This footnote also confirms that this email message has been swept by MIMEsweeper for the presence of computer viruses. www.mimesweeper.com **********************************************************************