From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2028 invoked from network); 20 Sep 2004 14:32:00 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 20 Sep 2004 14:32:00 -0000 Received: (qmail 35844 invoked from network); 20 Sep 2004 14:31:54 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 20 Sep 2004 14:31:54 -0000 Received: (qmail 3505 invoked by alias); 20 Sep 2004 14:31:39 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20394 Received: (qmail 3490 invoked from network); 20 Sep 2004 14:31:39 -0000 Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 20 Sep 2004 14:31:39 -0000 Received: (qmail 35289 invoked from network); 20 Sep 2004 14:30:39 -0000 Received: from lhuumrelay3.lnd.ops.eu.uu.net (62.189.58.19) by a.mx.sunsite.dk with SMTP; 20 Sep 2004 14:30:37 -0000 Received: from MAILSWEEPER01.csr.com (mailhost1.csr.com [62.189.183.235]) by lhuumrelay3.lnd.ops.eu.uu.net (8.11.0/8.11.0) with ESMTP id i8KEUZv01297 for ; Mon, 20 Sep 2004 14:30:35 GMT Received: from EXCHANGE02.csr.com (unverified [192.168.137.45]) by MAILSWEEPER01.csr.com (Content Technologies SMTPRS 4.3.12) with ESMTP id for ; Mon, 20 Sep 2004 15:29:37 +0100 Received: from news01.csr.com ([192.168.143.38]) by EXCHANGE02.csr.com with Microsoft SMTPSVC(5.0.2195.6713); Mon, 20 Sep 2004 15:32:02 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.12.11/8.12.11) with ESMTP id i8KEUWl9007684 for ; Mon, 20 Sep 2004 15:30:32 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.12.11/8.12.11/Submit) with ESMTP id i8KEUVjC007681 for ; Mon, 20 Sep 2004 15:30:31 +0100 Message-Id: <200409201430.i8KEUVjC007681@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk Subject: Re: PATCH: SHLVL not updated in environment In-reply-to: References: <200409201309.i8KD9QuP007197@news01.csr.com> Date: Mon, 20 Sep 2004 15:30:31 +0100 From: Peter Stephenson X-OriginalArrivalTime: 20 Sep 2004 14:32:02.0458 (UTC) FILETIME=[9833BFA0:01C49F1E] X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=0.0 required=6.0 tests=none autolearn=no version=2.63 X-Spam-Hits: 0.0 Bart Schaefer wrote: > I think it's right, but it begs the question: What changed from 4.2.0 > to make this fix necessary? The code changed from "right" to "wrong". It used to look like this. pm = (Param) paramtab->getnode(paramtab, "SHLVL"); if (!(pm->flags & PM_EXPORTED)) pm->flags |= PM_EXPORTED; sprintf(buf, "%d", (int)++shlvl); pm->env = addenv("SHLVL", buf, pm->flags); I rationalised addenv and in my zeal I probably didn't notice that the shlvl code wanted rationalising in a slightly different way from the others. The PM_EXPORTED flag is now handled within addenv(). So it looks like the patch is correct. -- Peter Stephenson Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This footnote also confirms that this email message has been swept by MIMEsweeper for the presence of computer viruses. www.mimesweeper.com **********************************************************************