zsh-workers
 help / color / mirror / code / Atom feed
From: Wayne Davison <wayned@users.sourceforge.net>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh-workers@sunsite.dk
Subject: Re: Completion for darcs
Date: Mon, 27 Sep 2004 17:03:03 -0700	[thread overview]
Message-ID: <20040928000303.GB12616@blorf.net> (raw)
In-Reply-To: <17141.1096275731@trentino.logica.co.uk>

On Mon, Sep 27, 2004 at 11:02:11AM +0200, Oliver Kiddle wrote:
> This doesn't complete filenames at all.

It includes files because the output of the darcs command lists what it
considers to be appropriate files for the command being completed.  (It
also lists other args, such as repository URLs and such.)

> We also don't need to grep for $PREFIX: matching is done far better
> internally. [...] We also don't need the _darcs() { ... } stuff and
> the compadds should go through _wanted (the second perhaps through
> _arguments). Return statements are also wrong.

Thanks for the notes.  Since I haven't created any completion functions
before, I had used what the darcs folks suggested with minimal changes.
I've just checked in an improved version based on your critique.  I hope
that it is somewhat better.

..wayne..


  reply	other threads:[~2004-09-28  0:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-25  0:38 Wayne Davison
2004-09-27  9:02 ` Oliver Kiddle
2004-09-28  0:03   ` Wayne Davison [this message]
     [not found] <20050401080620.GA16347@vandal.simcon-mt.de>
     [not found] ` <20050401080914.GB16347@vandal.simcon-mt.de>
     [not found]   ` <424D152C.2030006@free.fr>
     [not found]     ` <20050401123620.GA2607@ppe.happygiraffe.net>
     [not found]       ` <424D4A38.6010607@free.fr>
     [not found]         ` <20050405072940.GA9105@a5.repetae.net>
2005-04-05 13:03           ` completion " Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040928000303.GB12616@blorf.net \
    --to=wayned@users.sourceforge.net \
    --cc=okiddle@yahoo.co.uk \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).