[PATCH] fix portability bug in

[PATCH] fix portability bug in

[Borzenkov Andrey]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

Hi, long time have not been here :)

The patch from 20025 does not allow configure to run here because

- here /bin/sh (or /bin/ksh, does not matter) do not have SIGTTOU but just
TTOU so 'trap "" SIGTTOU' is an error

- according to SUS (Shell Command Language, 2.8.1) trap is special builtin
so non-zero exit code makes scripting shell immediately exit; the "trap ||
:" does not help.

The patch attempts to "fix" while still leaving trap in place. I do not know
why it is needed so I did not add "trap TTOU" (for my system :) In general
this looks rather inherently non-portable so the best way would be to get
rid of this trap at all (default for SIGTTOU is ignore anyway).

Please check if it still works for original problem.

Regards

-andrey



[-- Attachment #2: configure.ac.diff --]
[-- Type: application/octet-stream, Size: 975 bytes --]

Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.21
diff -u -r1.21 configure.ac
--- configure.ac	8 Oct 2004 14:36:54 -0000	1.21
+++ configure.ac	22 Oct 2004 11:40:54 -0000
@@ -1804,7 +1804,7 @@
 if test "x$ac_cv_func_tcsetpgrp" = xyes; then
 case "x$zsh_working_tcsetpgrp" in
   xcheck)
-    trap "" SIGTTOU > /dev/null 2>&1 || :
+    ( trap "" SIGTTOU > /dev/null 2>&1 ) && trap "" SIGTTOU > /dev/null 2>&1 
     AC_CACHE_CHECK(if tcsetpgrp() actually works,
     zsh_cv_sys_tcsetpgrp,
     [AC_TRY_RUN([
@@ -1835,7 +1835,7 @@
 Try running configure with --with-tcsetpgrp or --without-tcsetpgrp]);;
       *)      AC_MSG_ERROR([unexpected return status]);;
     esac
-    trap - SIGTTOU > /dev/null 2>&1 || :
+    ( trap - SIGTTOU > /dev/null 2>&1 ) && trap - SIGTTOU > /dev/null 2>&1 
     ;;
   xyes) :;;
   xno)  AC_DEFINE(BROKEN_TCSETPGRP);;

Re: [PATCH] fix portability bug in

[Peter Stephenson]

Borzenkov Andrey wrote:
> The patch from 20025 does not allow configure to run here because
> 
> - here /bin/sh (or /bin/ksh, does not matter) do not have SIGTTOU but just
> TTOU so 'trap "" SIGTTOU' is an error

Hmm, I think TTOU is standard anyway.  bash, ksh and zsh all work that
way.  I don't know of any shell that needs the SIG in front.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************