From: Geoff Wing <gcw@zsh.org>
To: Zsh Hackers <zsh-workers@sunsite.dk>
Subject: Re: [PATCH] Improved temp-file creation
Date: Fri, 29 Oct 2004 17:01:20 +1000 [thread overview]
Message-ID: <20041029070120.GA22848@primenet.com.au> (raw)
In-Reply-To: <20041019053736.GA23313@blorf.net>
Wayne Davison <wayned@users.sourceforge.net> output:
:--- Src/builtin.c 18 Oct 2004 19:07:50 -0000 1.130
:+++ Src/builtin.c 19 Oct 2004 05:32:17 -0000
[...]
:- if (((tempfd = open(fil, O_WRONLY | O_CREAT | O_EXCL | O_NOCTTY, 0600))
:--- Src/exec.c 18 Oct 2004 19:07:55 -0000 1.75
:+++ Src/exec.c 19 Oct 2004 05:32:19 -0000
[...]
:- if (!s || (fd = open(s, O_CREAT|O_WRONLY|O_EXCL|O_NOCTTY, 0600)) == -1)
:+gettempfile(const char *prefix, int use_heap, char **tempname)
[...]
:+ if ((fd = open(fn, O_RDWR | O_CREAT | O_EXCL, 0600)) >= 0)
You've replaced a couple of open()s which were O_NOCTTY with one that isn't.
Does this affect anything? Were they erroneously O_NOCTTY or were they
specifically that way for scripts or something else? You haven't mentioned
either here or in the ChangeLog that this was intentional.
Regards,
Geoff
next prev parent reply other threads:[~2004-10-29 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 5:37 Wayne Davison
2004-10-29 7:01 ` Geoff Wing [this message]
2004-10-29 16:07 ` Wayne Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041029070120.GA22848@primenet.com.au \
--to=gcw@zsh.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).