From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6424 invoked from network); 29 Oct 2004 07:02:44 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 29 Oct 2004 07:02:44 -0000 Received: (qmail 55178 invoked from network); 29 Oct 2004 07:02:38 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 29 Oct 2004 07:02:38 -0000 Received: (qmail 13354 invoked by alias); 29 Oct 2004 07:02:25 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20527 Received: (qmail 13324 invoked from network); 29 Oct 2004 07:02:24 -0000 Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 29 Oct 2004 07:02:24 -0000 Received: (qmail 54543 invoked from network); 29 Oct 2004 07:01:25 -0000 Received: from g.primenet.com.au (203.24.36.10) by a.mx.sunsite.dk with SMTP; 29 Oct 2004 07:01:23 -0000 Received: (qmail 13265 invoked by uid 100); 29 Oct 2004 07:01:20 -0000 Date: Fri, 29 Oct 2004 17:01:20 +1000 From: Geoff Wing To: Zsh Hackers Subject: Re: [PATCH] Improved temp-file creation Message-ID: <20041029070120.GA22848@primenet.com.au> References: <20041019053736.GA23313@blorf.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019053736.GA23313@blorf.net> User-Agent: Mutt/1.4.2.1i Organization: PrimeNet Computer Consultancy X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=-0.0 required=6.0 tests=BAYES_40 autolearn=no version=2.63 X-Spam-Hits: -0.0 Wayne Davison output: :--- Src/builtin.c 18 Oct 2004 19:07:50 -0000 1.130 :+++ Src/builtin.c 19 Oct 2004 05:32:17 -0000 [...] :- if (((tempfd = open(fil, O_WRONLY | O_CREAT | O_EXCL | O_NOCTTY, 0600)) :--- Src/exec.c 18 Oct 2004 19:07:55 -0000 1.75 :+++ Src/exec.c 19 Oct 2004 05:32:19 -0000 [...] :- if (!s || (fd = open(s, O_CREAT|O_WRONLY|O_EXCL|O_NOCTTY, 0600)) == -1) :+gettempfile(const char *prefix, int use_heap, char **tempname) [...] :+ if ((fd = open(fn, O_RDWR | O_CREAT | O_EXCL, 0600)) >= 0) You've replaced a couple of open()s which were O_NOCTTY with one that isn't. Does this affect anything? Were they erroneously O_NOCTTY or were they specifically that way for scripts or something else? You haven't mentioned either here or in the ChangeLog that this was intentional. Regards, Geoff