zsh-workers
 help / color / mirror / code / Atom feed
From: Wayne Davison <wayned@users.sourceforge.net>
To: Geoff Wing <gcw@zsh.org>
Cc: Zsh Hackers <zsh-workers@sunsite.dk>
Subject: Re: [PATCH] Improved temp-file creation
Date: Fri, 29 Oct 2004 09:07:36 -0700	[thread overview]
Message-ID: <20041029160736.GB23648@blorf.net> (raw)
In-Reply-To: <20041029070120.GA22848@primenet.com.au>

On Fri, Oct 29, 2004 at 05:01:20PM +1000, Geoff Wing wrote:
> You've replaced a couple of open()s which were O_NOCTTY with one that isn't.

Correct.  I had meant to discuss that, but neglected to do so.

Since we're using O_CREAT to ensure that we open a new file, I didn't
see any need to also specify O_NOCTTY -- i.e. how can the file be a tty
if it was just created?

Since some of the replaced open() calls used O_CREAT included O_NOCTTY
and some didn't, I chose to settle on leaving it out.  If I was wrong
about the flag being useless, we can add it back in.

Thanks for checking over the changes!

..wayne..


      reply	other threads:[~2004-10-29 16:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-19  5:37 Wayne Davison
2004-10-29  7:01 ` Geoff Wing
2004-10-29 16:07   ` Wayne Davison [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041029160736.GB23648@blorf.net \
    --to=wayned@users.sourceforge.net \
    --cc=gcw@zsh.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).