From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9403 invoked from network); 29 Oct 2004 16:09:07 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 29 Oct 2004 16:09:07 -0000 Received: (qmail 12556 invoked from network); 29 Oct 2004 16:09:01 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 29 Oct 2004 16:09:01 -0000 Received: (qmail 27364 invoked by alias); 29 Oct 2004 16:08:07 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20529 Received: (qmail 27332 invoked from network); 29 Oct 2004 16:08:05 -0000 Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 29 Oct 2004 16:08:05 -0000 Received: (qmail 10403 invoked from network); 29 Oct 2004 16:07:39 -0000 Received: from dsl3-63-249-88-2.cruzio.com (HELO binome.blorf.net) (63.249.88.2) by a.mx.sunsite.dk with SMTP; 29 Oct 2004 16:07:38 -0000 Received: by binome.blorf.net (Postfix, from userid 1000) id 188DD2D10; Fri, 29 Oct 2004 09:07:37 -0700 (PDT) Date: Fri, 29 Oct 2004 09:07:36 -0700 From: Wayne Davison To: Geoff Wing Cc: Zsh Hackers Subject: Re: [PATCH] Improved temp-file creation Message-ID: <20041029160736.GB23648@blorf.net> References: <20041019053736.GA23313@blorf.net> <20041029070120.GA22848@primenet.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041029070120.GA22848@primenet.com.au> User-Agent: Mutt/1.5.6+20040907i X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=-0.0 required=6.0 tests=BAYES_44 autolearn=no version=2.63 X-Spam-Hits: -0.0 On Fri, Oct 29, 2004 at 05:01:20PM +1000, Geoff Wing wrote: > You've replaced a couple of open()s which were O_NOCTTY with one that isn't. Correct. I had meant to discuss that, but neglected to do so. Since we're using O_CREAT to ensure that we open a new file, I didn't see any need to also specify O_NOCTTY -- i.e. how can the file be a tty if it was just created? Since some of the replaced open() calls used O_CREAT included O_NOCTTY and some didn't, I chose to settle on leaving it out. If I was wrong about the flag being useless, we can add it back in. Thanks for checking over the changes! ..wayne..