From: Wayne Davison <wayned@users.sourceforge.net>
To: Clint Adams <clint@zsh.org>
Cc: zsh-workers@sunsite.dk
Subject: Re: [lunz@falooley.org: Bug#279417: zsh: "make" completion issues "bad option" warnings for some Makefiles]
Date: Wed, 10 Nov 2004 09:27:18 -0800 [thread overview]
Message-ID: <20041110172718.GA31676@blorf.net> (raw)
In-Reply-To: <20041102231304.GA15509@scowler.net>
On Tue, Nov 02, 2004 at 06:13:04PM -0500, Clint Adams wrote:
> This prevents the warnings, though I don't know if there's a deeper
> problem occurring here.
Your fix looks right to me for the root of the problem.
One other potential parsing problem that occurred to me while looking at
this was that "$$" wasn't being interpreted properly. The following
patch should make it better (though not 100% foolproof, it should
hopefully be adequate for our purposes).
--- Completion/Unix/Command/_make 2 Nov 2004 23:26:42 -0000 1.12
+++ Completion/Unix/Command/_make 10 Nov 2004 17:18:53 -0000
@@ -22,6 +22,10 @@ expandVars() {
close=''
var=${(s::)var[1]}
;;
+ (\$*)
+ # avoid parsing second $ in $$
+ tmp=${tmp#\$}
+ continue
(*)
continue
;;
@@ -38,7 +42,7 @@ expandVars() {
;;
esac
else
- print -- $ret
+ print -- ${ret//\$\$/\$}
return
fi
done
..wayne..
prev parent reply other threads:[~2004-11-10 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 23:13 Clint Adams
2004-11-10 17:27 ` Wayne Davison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041110172718.GA31676@blorf.net \
--to=wayned@users.sourceforge.net \
--cc=clint@zsh.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).