From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16434 invoked from network); 29 Nov 2004 16:53:29 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 29 Nov 2004 16:53:29 -0000 Received: (qmail 2297 invoked from network); 29 Nov 2004 16:53:24 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 29 Nov 2004 16:53:24 -0000 Received: (qmail 19103 invoked by alias); 29 Nov 2004 16:53:19 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20596 Received: (qmail 19087 invoked from network); 29 Nov 2004 16:53:18 -0000 Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 29 Nov 2004 16:53:18 -0000 Received: (qmail 1396 invoked from network); 29 Nov 2004 16:52:19 -0000 Received: from mailhost1.csr.com (HELO MAILSWEEPER01.csr.com) (81.105.217.43) by a.mx.sunsite.dk with SMTP; 29 Nov 2004 16:52:17 -0000 Received: from exchange03.csr.com (unverified [10.100.137.60]) by MAILSWEEPER01.csr.com (Content Technologies SMTPRS 4.3.12) with ESMTP id for ; Mon, 29 Nov 2004 16:51:05 +0000 Received: from news01.csr.com ([10.103.143.38]) by exchange03.csr.com with Microsoft SMTPSVC(5.0.2195.6713); Mon, 29 Nov 2004 16:52:38 +0000 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.12.11/8.12.11) with ESMTP id iATGqG13022057 for ; Mon, 29 Nov 2004 16:52:16 GMT Received: from csr.com (pws@localhost) by news01.csr.com (8.12.11/8.12.11/Submit) with ESMTP id iATGqFMM022054 for ; Mon, 29 Nov 2004 16:52:15 GMT Message-Id: <200411291652.iATGqFMM022054@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: Zsh hackers list Subject: Re: zsh coding standards In-reply-to: <20041129164253.GA539@blorf.net> References: <20041129115700.GA4569@sc> <200411291210.iATCA9wt020885@news01.csr.com> <20041129164253.GA539@blorf.net> Date: Mon, 29 Nov 2004 16:52:15 +0000 From: Peter Stephenson X-OriginalArrivalTime: 29 Nov 2004 16:52:38.0699 (UTC) FILETIME=[D58277B0:01C4D633] X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=0.0 required=6.0 tests=none autolearn=no version=2.63 X-Spam-Hits: 0.0 Wayne Davison wrote: > Speaking of coding standards, it has only been fairly recently (perhaps > this year?) that you have started to put braces on the line following an > "if", "while", etc. Is this a conscious decision to change zsh's coding > style? I personally prefer seeing the braces on the same line as the > controlling statement (except for the start of a function). It's because that's how we do it at CSR, and switching between the two is too complicated for me. It's not intentional. > Use "{}" on an empty loop instead of ";" to make it more obvious that no > looping statements follow. I think this is mostly done by putting the ";" on the next line, which makes the intention clear enough. Putting a ";" on the same line immediately after the loop statement is certainly more bug-prone. > Attached is a patch of the zchdir() function that contains only the style > changes mentioned above. They won't be committed unless agreement is > reached that they would be a good thing. Anything that makes it more readable is fine by me, although it's quite hard to enforce this sort of nicety. -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This footnote also confirms that this email message has been swept by MIMEsweeper for the presence of computer viruses. www.mimesweeper.com **********************************************************************