New Test Failure

New Test Failure

[Vin Shelton]

It looks like the $(##) change broke something:

cd Test ; make check
make[1]: Entering directory `/u/sheltonv/software/SunOS-5.8/build/zsh-2004-11-30/Test'
if test -n "cc"; then \
  cd .. && DESTDIR= \
  make MODDIR=`pwd`/Test/Modules install.modules > /dev/null; \
fi
mkdir /u/sheltonv/software/SunOS-5.8/build/zsh-2004-11-30/Test/Modules
mkdir /u/sheltonv/software/SunOS-5.8/build/zsh-2004-11-30/Test/Modules/zsh
mkdir /u/sheltonv/software/SunOS-5.8/build/zsh-2004-11-30/Test/Modules/zsh/net
for f in /u/sheltonv/software/SunOS-5.8/src/zsh-2004-11-30/Test/C01*.ztst; do \
  ZTST_exe=../Src/zsh \
    ../Src/zsh +Z -f /u/sheltonv/software/SunOS-5.8/src/zsh-2004-11-30/Test/ztst.zsh $f; \
done
/u/sheltonv/software/SunOS-5.8/src/zsh-2004-11-30/Test/C01arith.ztst: starting.
ZTST_getsect: read section name: test
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  integer light there
ZTST_getchunk: read code chunk:
  integer light there
  (( light = 42 )) &&
  let 'there = light' &&
  print $(( there ))
ZTST_test: examining line:
>42
ZTST_getredir: read redir for '>':
42
ZTST_test: examining line:

Running test: basic integer arithmetic
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
42
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  float light there
ZTST_getchunk: read code chunk:
  float light there
  integer rnd
  (( light = 3.1415 )) &&
  let 'there = light' &&
  print -- $(( rnd = there * 10000 ))
ZTST_test: examining line:
>31415.
ZTST_getredir: read redir for '>':
31415.
ZTST_test: examining line:

Running test: basic floating point arithmetic
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
31415.
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  print $(( 0x10 + 0X01 + 2#1010 ))
ZTST_getchunk: read code chunk:
  print $(( 0x10 + 0X01 + 2#1010 ))
ZTST_test: examining line:
>27
ZTST_getredir: read redir for '>':
27
ZTST_test: examining line:

Running test: base input
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
27
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  float light
ZTST_getchunk: read code chunk:
  float light
  (( light = 4 ))
  print $light
  typeset -F light
  print $light
ZTST_test: examining line:
>4.000000000e+00
ZTST_getredir: read redir for '>':
4.000000000e+00
4.0000000000
ZTST_test: examining line:

Running test: conversion to float
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
4.000000000e+00
4.0000000000
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  integer i
ZTST_getchunk: read code chunk:
  integer i
  (( i = 32.5 ))
  print $i
ZTST_test: examining line:
>32
ZTST_getredir: read redir for '>':
32
ZTST_test: examining line:

Running test: conversion to int
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
32
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  integer i
ZTST_getchunk: read code chunk:
  integer i
  (( i = 4 - - 3 * 7 << 1 & 7 ^ 1 | 16 ** 2 ))
  print $i
ZTST_test: examining line:
>1591
ZTST_getredir: read redir for '>':
1591
ZTST_test: examining line:

Running test: precedence (arithmetic)
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
1591
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  print $(( 1 < 2 || 2 < 2 && 3 > 4 ))
ZTST_getchunk: read code chunk:
  print $(( 1 < 2 || 2 < 2 && 3 > 4 ))
ZTST_test: examining line:
>1
ZTST_getredir: read redir for '>':
1
ZTST_test: examining line:

Running test: precedence (logical)
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
1
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  print $(( 1 + 4 ? 3 + 2 ? 4 + 3 ? 5 + 6 ? 4 * 8 : 0 : 0 : 0 : 0 ))
ZTST_getchunk: read code chunk:
  print $(( 1 + 4 ? 3 + 2 ? 4 + 3 ? 5 + 6 ? 4 * 8 : 0 : 0 : 0 : 0 ))
ZTST_test: examining line:
>32
ZTST_getredir: read redir for '>':
32
ZTST_test: examining line:

Running test: precedence (ternary)
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
32
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  print $(( 3 ? 2 ))
ZTST_getchunk: read code chunk:
  print $(( 3 ? 2 ))
ZTST_test: examining line:
?(eval):1: ':' expected
ZTST_getredir: read redir for '?':
(eval):1: ':' expected
ZTST_test: examining line:

Running test: parsing ternary (1)
ZTST_test: expecting status: 1
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 1
ZTST_test: test produced standard output:

ZTST_test: and standard error:
(eval):1: ':' expected
Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  print $(( 3 ? 2 : 1 : 4 ))
ZTST_getchunk: read code chunk:
  print $(( 3 ? 2 : 1 : 4 ))
ZTST_test: examining line:
?(eval):1: ':' without '?'
ZTST_getredir: read redir for '?':
(eval):1: ':' without '?'
ZTST_test: examining line:

Running test: parsing ternary (2)
ZTST_test: expecting status: 1
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 1
ZTST_test: test produced standard output:

ZTST_test: and standard error:
(eval):1: ':' without '?'
Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  print $(( 0, 4 ? 3 : 1, 5 ))
ZTST_getchunk: read code chunk:
  print $(( 0, 4 ? 3 : 1, 5 ))
ZTST_test: examining line:
>5
ZTST_getredir: read redir for '>':
5
ZTST_test: examining line:

Running test: comma operator
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
5
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  foo=000
ZTST_getchunk: read code chunk:
  foo=000
  print $(( ##A + ##\C-a + #foo + $#foo ))
ZTST_test: examining line:
>117
ZTST_getredir: read redir for '>':
117
ZTST_test: examining line:

Running test: #, ## and $#
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
117
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  print $((##))
ZTST_getchunk: read code chunk:
  print $((##))
ZTST_test: examining line:
>0
ZTST_getredir: read redir for '>':
0
ZTST_test: examining line:

Running test: ## without following character
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.5429, output: /tmp/zsh.ztst.out.5429, error: /tmp/zsh.ztst.terr.5429
ZTST_execchunk: status 1
Test /u/sheltonv/software/SunOS-5.8/src/zsh-2004-11-30/Test/C01arith.ztst failed: bad status 1, expected 0 from:
  print $((##))
Error output:
(eval):1: character missing after ##
Was testing: ## without following character
/u/sheltonv/software/SunOS-5.8/src/zsh-2004-11-30/Test/C01arith.ztst: test failed.
make[1]: [check] Error 1 (ignored)
rm -rf Modules .zcompdump
make[1]: Leaving directory `/u/sheltonv/software/SunOS-5.8/build/zsh-2004-11-30/Test'

HTH,
  Vin

-- 
In a minute there is time
For decisions and revisions which a minute will reverse.         T.S. Eliot
[URL: http://www.cs.amherst.edu/~ccm/prufrock.html]

Re: New Test Failure

[Peter Stephenson]

Vin Shelton wrote:
> It looks like the $(##) change broke something:

Yes, the test is now wrong.  $((##)) never did anything useful, it's
better to report an error.

Index: Test/C01arith.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/C01arith.ztst,v
retrieving revision 1.8
diff -u -r1.8 C01arith.ztst
--- Test/C01arith.ztst	13 May 2004 20:04:25 -0000	1.8
+++ Test/C01arith.ztst	30 Nov 2004 14:01:52 -0000
@@ -69,8 +69,8 @@
 >117
 
   print $((##))
-0:## without following character
->0
+1:## without following character
+?(eval):1: character missing after ##
 
   print $((## ))
 0:## followed by a space

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************

Re: New test failure

[Bart Schaefer]

On Feb 22,  8:59am, Vin Shelton wrote:
}
} I didn't follow the discussion closely, but I think the recent
} shwordsplit changes require a test update:

Oops, that should have been committed along with Src/subst.c.

Done.

New test failure

[Vin Shelton]

I didn't follow the discussion closely, but I think the recent
shwordsplit changes require a test update:

Running test: SH_WORD_SPLIT inside $(...) inside ${...}
*** /tmp/zsh.ztst.out.31468     Wed Feb 22 08:49:19 2012
--- /tmp/zsh.ztst.tout.31468    Wed Feb 22 08:49:19 2012
***************
*** 1 ****
! _'one' 'two' 'three'_
--- 1,3 ----
! _'one'
! 'two'
! 'three'_
Test /opt/src/zsh-2012-02-22/Test/D04parameter.ztst failed: output
differs from expected as shown above for:
  (setopt shwordsplit # ensure this doesn't get set in main shell...
  test_splitting ()
  {
    array="one two three"
    for e in $array; do
      echo "'$e'"
    done
  }
  test_split_var=
  : ${test_split_var:=$(test_splitting)}
  echo "_${test_split_var}_")
Was testing: SH_WORD_SPLIT inside $(...) inside ${...}
/opt/src/zsh-2012-02-22/Test/D04parameter.ztst: test failed.


  - Vin