From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-20652-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 2669 invoked from network); 8 Jan 2005 18:17:35 -0000
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by ns1.primenet.com.au with SMTP; 8 Jan 2005 18:17:35 -0000
Received: (qmail 80763 invoked from network); 8 Jan 2005 18:17:29 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 8 Jan 2005 18:17:29 -0000
Received: (qmail 9550 invoked by alias); 8 Jan 2005 18:17:15 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 20652
Received: (qmail 9535 invoked from network); 8 Jan 2005 18:17:15 -0000
Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88)
  by sunsite.dk with SMTP; 8 Jan 2005 18:17:15 -0000
Received: (qmail 80068 invoked from network); 8 Jan 2005 18:16:15 -0000
Received: from dsl3-63-249-88-2.cruzio.com (HELO binome.blorf.net) (63.249.88.2)
  by a.mx.sunsite.dk with SMTP; 8 Jan 2005 18:16:12 -0000
Received: by binome.blorf.net (Postfix, from userid 1000)
	id BF8FF260B; Sat,  8 Jan 2005 10:16:09 -0800 (PST)
Date: Sat, 8 Jan 2005 10:16:09 -0800
From: Wayne Davison <wayned@users.sourceforge.net>
To: "?$B9a@n ?$BOK" <wkagawa@jota.gsc.riken.go.jp>
Cc: zsh-workers@sunsite.dk
Subject: Re: Minor bugs in _unsetopt and _main_complete ?
Message-ID: <20050108181609.GA12504@blorf.net>
References: <D0867C35-4A52-11D9-A8CE-000A95A6799C@jota.gsc.riken.go.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <D0867C35-4A52-11D9-A8CE-000A95A6799C@jota.gsc.riken.go.jp>
User-Agent: Mutt/1.5.6+20040907i
X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk
X-Spam-Level: 
X-Spam-Status: No, hits=0.0 required=6.0 tests=none autolearn=no version=2.63
X-Spam-Hits: 0.0

[I had thought that someone else would respond to this message, but
since no one did, let me give you a late reply.]

On Fri, Dec 10, 2004 at 11:25:53AM +0900, ?$B9a@n ?$BOK wrote:
> In _unsetopt, "_options_set || _options" should be,
> 
> _options_unset || _options
> 
> and in _main_complete,
> 
> _options_set=(${(k)options[(R)on]})
> _options_unset=(${(k)options[(R)off]})
> 
> should be,
> 
> _options_set=(${(k)options[(R)off]})
> _options_unset=(${(k)options[(R)on]})

You seem to be thinking about the variables in the opposite manner in
which they were intended.  The _options_set variable contains set
options (not options that can be set), so it is used to complete
unsettable options in _unsetopt.  I think this interpretation of the
options is evident in this comment in _main_complete:

    # If you want to complete only set or unset options for the unsetopt
    # and setopt builtin, un-comment these lines:

This is followed by _options_set (the set options) and _options_unset
(the unset options).  Certainly, your choice to reverse the meaning in
both the setting and use of these variables will work fine for your
configuration, but I think the CVS version should remain unchanged.

..wayne..