From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29643 invoked from network); 26 Jan 2005 14:27:40 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 26 Jan 2005 14:27:40 -0000 Received: (qmail 98854 invoked from network); 26 Jan 2005 14:27:30 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 26 Jan 2005 14:27:30 -0000 Received: (qmail 5058 invoked by alias); 26 Jan 2005 14:27:27 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20751 Received: (qmail 5048 invoked from network); 26 Jan 2005 14:27:27 -0000 Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 26 Jan 2005 14:27:27 -0000 Received: (qmail 98446 invoked from network); 26 Jan 2005 14:26:51 -0000 Received: from acolyte.scowler.net (216.254.112.45) by a.mx.sunsite.dk with SMTP; 26 Jan 2005 14:26:47 -0000 Received: by acolyte.scowler.net (Postfix, from userid 1000) id 6894D7004D; Wed, 26 Jan 2005 09:26:45 -0500 (EST) Date: Wed, 26 Jan 2005 09:26:45 -0500 From: Clint Adams To: Peter Stephenson Cc: Zsh hackers list Subject: Re: PATCH: Unicode additions, next phase. Message-ID: <20050126142645.GA31701@scowler.net> Mail-Followup-To: Peter Stephenson , Zsh hackers list References: <200501251446.j0PEkoFJ024136@news01.csr.com> <20050126022947.GA12574@scowler.net> <200501261033.j0QAXmjA032042@news01.csr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200501261033.j0QAXmjA032042@news01.csr.com> User-Agent: Mutt/1.5.6+20040907i X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 > Plus we'll probably need to have wcwidth on the menu at some Oh dear.. also any memory allocations based on winw have to be modified. > point... not sure if that helps with wide characters that are control > characters (do these exist?), probably not. I'd be tempted to see if > control characters were converted to a single byte string, if they do > print them as at present, and if they don't just skip them; same for > conversion failures, although that shouldn't happen for characters that > convert to 7-bit ASCII anyway. This uses '?' for both eventualities. That might obscure character conversion errors. Index: Src/Zle/zle_refresh.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_refresh.c,v retrieving revision 1.15 diff -u -r1.15 zle_refresh.c --- Src/Zle/zle_refresh.c 26 Jan 2005 13:39:52 -0000 1.15 +++ Src/Zle/zle_refresh.c 26 Jan 2005 14:24:23 -0000 @@ -478,7 +478,7 @@ nextline } #ifdef ZLE_UNICODE_SUPPORT -# error What to do here + *s++ = ((*t == 127) || (*t > 255)) ? '?' : (*t | '@'); #else *s++ = (*t == 127) ? '?' : (*t | '@'); #endif @@ -488,7 +488,7 @@ i = wcrtomb(s, *t, &shiftstate); if (i == -1) { - /* error; what to do? */ + *s++ = '?'; } else { s += i; }