From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19866 invoked from network); 2 Mar 2005 18:52:06 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 2 Mar 2005 18:52:06 -0000 Received: (qmail 45319 invoked from network); 2 Mar 2005 18:52:00 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 2 Mar 2005 18:52:00 -0000 Received: (qmail 12366 invoked by alias); 2 Mar 2005 18:51:57 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20915 Received: (qmail 12356 invoked from network); 2 Mar 2005 18:51:57 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 2 Mar 2005 18:51:57 -0000 Received: (qmail 44965 invoked from network); 2 Mar 2005 18:51:54 -0000 Received: from dsl3-63-249-88-2.cruzio.com (HELO binome.blorf.net) (63.249.88.2) by a.mx.sunsite.dk with SMTP; 2 Mar 2005 18:51:49 -0000 Received: by binome.blorf.net (Postfix, from userid 1000) id 3F5FB36AF; Wed, 2 Mar 2005 10:51:47 -0800 (PST) Date: Wed, 2 Mar 2005 10:51:47 -0800 From: Wayne Davison To: zsh-workers@sunsite.dk Subject: Re: [stew@vireo.org: Bug#295511: patch] Message-ID: <20050302185147.GC21435@blorf.net> References: <20050302052845.GA27771@scowler.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050302052845.GA27771@scowler.net> User-Agent: Mutt/1.5.6+20040907i X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 On Wed, Mar 02, 2005 at 12:28:45AM -0500, Clint Adams wrote: > Wayne, any thoughts? Hmm, I failed to notice that this Debian bug was talking about the _make completer. It looks to me like the main problem is that the script has a reference to $1 in some $(shell ...) expansions, and the _make script is expanding this into the arg that is being expanded, causing an infinite loop. So, I think it would be good to work up a patch that would cause the _make script to avoid trying to expand (or set) numeric arg variables (I'll look into this). However, the patch you cited that limits recursion-depth also appears to be a reasonable precaution to avoid a problem like this in the future. It looks good enough to check-in to me -- if you agree, feel free (or ask me to do so). ..wayne..