From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21900 invoked from network); 2 Mar 2005 19:17:50 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 2 Mar 2005 19:17:50 -0000 Received: (qmail 68275 invoked from network); 2 Mar 2005 19:17:43 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 2 Mar 2005 19:17:43 -0000 Received: (qmail 26060 invoked by alias); 2 Mar 2005 19:17:41 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20917 Received: (qmail 26047 invoked from network); 2 Mar 2005 19:17:40 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 2 Mar 2005 19:17:40 -0000 Received: (qmail 68073 invoked from network); 2 Mar 2005 19:17:37 -0000 Received: from dsl3-63-249-88-2.cruzio.com (HELO binome.blorf.net) (63.249.88.2) by a.mx.sunsite.dk with SMTP; 2 Mar 2005 19:17:32 -0000 Received: by binome.blorf.net (Postfix, from userid 1000) id DC3853730; Wed, 2 Mar 2005 11:17:31 -0800 (PST) Date: Wed, 2 Mar 2005 11:17:31 -0800 From: Wayne Davison To: zsh-workers@sunsite.dk Subject: Re: [stew@vireo.org: Bug#295511: patch] Message-ID: <20050302191731.GD21435@blorf.net> References: <20050302052845.GA27771@scowler.net> <20050302185147.GC21435@blorf.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050302185147.GC21435@blorf.net> User-Agent: Mutt/1.5.6+20040907i X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 On Wed, Mar 02, 2005 at 10:51:47AM -0800, Wayne Davison wrote: > So, I think it would be good to work up a patch that would cause the > _make script to avoid trying to expand (or set) numeric arg variables The fix to avoid expanding something like $1 was trivial, so I checked it in to both the trunk and the patches branch: --- Completion/Unix/Command/_make 11 Nov 2004 19:05:25 -0000 1.14 +++ Completion/Unix/Command/_make 2 Mar 2005 19:06:23 -0000 1.15 @@ -17,7 +17,7 @@ expandVars() { open='{' close='}' ;; - ([[:alnum:]]*) + ([[:alpha:]]*) open='' close='' var=${(s::)var[1]} This change avoids the infinite recursion cited in Debug bug #295511. ..wayne..