zsh-workers
 help / color / mirror / code / Atom feed
From: Andrey Borzenkov <arvidjaar@newmail.ru>
To: zsh-workers@sunsite.dk
Subject: Re: [PATCH] _fuser Solaris and SVR4 support
Date: Tue, 22 Mar 2005 21:46:11 +0300	[thread overview]
Message-ID: <200503222146.12289.arvidjaar@newmail.ru> (raw)
In-Reply-To: <9029.1111424918@trentino.groupinfra.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 21 March 2005 20:08, Oliver Kiddle wrote:
> On 12 Mar, Andrey wrote:
> > I actually meant - signal names should be completed only if -k is present
> > (because they are meaningless without). But currently it is possible to
> > implement only using ->state and it seemed too much work for such small
> > function.
>
> Normally we implement that by just checking for $+words[(r)-k]

Oops.

> Does the new patch below now do the right thing?
>

well, except at it turned out it was impossible to complete file name as first 
argument; also fuser takes more than one file.

Is the following the right way to do it?

- -andrey

===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_fuser,v
retrieving revision 1.2
diff -u -p -r1.2 _fuser
- --- Completion/Unix/Command/_fuser      10 Mar 2005 18:38:16 -0000      1.2
+++ Completion/Unix/Command/_fuser      22 Mar 2005 13:16:45 -0000
@@ -27,7 +27,7 @@ else
       )
     ;;
     sysv4 )
- -      arg1=( ':signal:_signals -p' )
+      (( $+words[(r)-k] )) && arg1=( ':signal: _alternative 
signals\:signals\:_signals\ -p files:files:_files' )
     ;;
   esac

@@ -38,5 +38,5 @@ else
         '-u[append the user name of the process owner to each PID]' \
         $args \
         $arg1 \
- -        ':name:_files'
+        '*:name:_files'
 fi

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCQGf0R6LMutpd94wRAmukAKC2NGrLVjGxAs/ezs8D8Fk+UD0fvACdHbFt
8IuJko+PJDQ0EhYXqmKyhqo=
=bH6f
-----END PGP SIGNATURE-----


  reply	other threads:[~2005-03-22 18:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-10 15:04 Andrey Borzenkov
2005-03-11  9:37 ` Oliver Kiddle
2005-03-12  7:46   ` Andrey Borzenkov
2005-03-21 17:08     ` Oliver Kiddle
2005-03-22 18:46       ` Andrey Borzenkov [this message]
2005-03-22 19:28         ` Oliver Kiddle
2005-03-11 10:47 ` Danek Duvall
2005-03-11 11:15   ` Oliver Kiddle
2005-03-12  7:53     ` Andrey Borzenkov
2005-03-12  7:55   ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503222146.12289.arvidjaar@newmail.ru \
    --to=arvidjaar@newmail.ru \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).