Re: Bug#303278: zsh: completions for gv are for pre 3.6

Re: Bug#303278: zsh: completions for gv are for pre 3.6

[Clint Adams]

> The completion for gv (functions/Completion/X/_gv) uses the pre-3.6
> single dash command line arguments rather than the new POSIX-like
> syntax used (with two dashes) in 3.6.  The easiest way to detect

Is it worth it to check which version of gv is in use?

Index: Completion/X/Command/_gv
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/X/Command/_gv,v
retrieving revision 1.1
diff -u -r1.1 _gv
--- Completion/X/Command/_gv	2 Apr 2001 12:13:49 -0000	1.1
+++ Completion/X/Command/_gv	5 Apr 2005 19:03:58 -0000
@@ -1,39 +1,42 @@
-#compdef gv gview
+#compdef gv
 
-_xt_arguments \
-  '(-nosafer)-safer' \
-  '(-safer)-nosafer' \
-  '(-noquiet)-quiet' \
-  '(-quiet)-noquiet' \
-  '(-nocenter)-center' \
-  '(-center)-nocenter' \
-  '(-noswap)-swap' \
-  '(-swap)-noswap' \
-  '(-noantialias)-antialias' \
-  '(-antialias)-noantialias' \
-  '(-nodsc)-dsc' \
-  '(-dsc)-nodsc' \
-  '(-noeof)-eof' \
-  '(-eof)-noeof' \
-  '(-nopixmap)-pixmap' \
-  '(-pixmap)-nopixmap' \
-  '(-nowatch)-watch' \
-  '(-watch)-nowatch' \
-  '(-noresize)-resize' \
-  '(-resize)-noresize' \
-  '(-grayscale -color)-monochrome' \
-  '(-monochrome -color)-grayscale' \
-  '(-grayscale -color)-monochrome' \
-  '(-landscape -seascape -upsidedown)-portrait' \
-  '(-portrait -seascape -upsidedown)-landscape' \
-  '(-portrait -landscape -upsidedown)-seascape' \
-  '(-portrait -landscape -seascape)-upsidedown' \
-  -{h,help,v,spartan} \
-  '-arguments:ghostscript arguments:' \
-  '-page:label of first page:' \
-  '-media:page size:(Letter Legal Statement Tabloid Ledger Folio Quarto 10x14 Executive A3 A4 A5 B4 B5)' \
-  '-scale:scale entry:' \
-  '-scalebase:scale base:' \
-  '-ad:resource file:_files' \
-  '-style:resource file:_files' \
-  '*:file: _pspdf -z'
+_arguments \
+  '-geometry:geometry:_x_geometry' \
+  '(--nosafer)--safer' \
+  '(--safer)--nosafer' \
+  '(--noquiet)--quiet' \
+  '(--quiet)--noquiet' \
+  '(--nocenter)--center' \
+  '(--center)--nocenter' \
+  '(--noswap)--swap' \
+  '(--swap)--noswap' \
+  '(--noantialias)--antialias' \
+  '(--antialias)--noantialias' \
+  '(--nodsc)--dsc' \
+  '(--dsc)--nodsc' \
+  '(--noeof)--eof' \
+  '(--eof)--noeof' \
+  '(--nopixmap)--pixmap' \
+  '(--pixmap)--nopixmap' \
+  '(--nowatch)--watch' \
+  '(--watch)--nowatch' \
+  '(--noresize)--resize' \
+  '(--resize)--noresize' \
+  '(--grayscale --color)--monochrome' \
+  '(--monochrome --color)--grayscale' \
+  '(--grayscale --color)--monochrome' \
+  '(--landscape --seascape --upsidedown)--portrait' \
+  '(--portrait --seascape --upsidedown)--landscape' \
+  '(--portrait --landscape --upsidedown)--seascape' \
+  '(--portrait --landscape --seascape)--upsidedown' \
+  --{help,spartan} \
+  -{h,v} \
+  '--arguments=:ghostscript arguments:' \
+  '--page=:label of first page:' \
+  '--media=:page size:(Letter Legal Statement Tabloid Ledger Folio Quarto 10x14 Executive A3 A4 A5 B4 B5)' \
+  '--orientation=:orientation:' \
+  '--scale=:scale entry:' \
+  '--scalebase=:scale base:' \
+  '--ad=:resource file:_files' \
+  '--style=:resource file:_files' \
+  '*:file: _pspdf --z'

Re: Bug#303278: zsh: completions for gv are for pre 3.6

[Oliver Kiddle]

Clint wrote:
> > The completion for gv (functions/Completion/X/_gv) uses the pre-3.6
> > single dash command line arguments rather than the new POSIX-like

Aren't two dashes a GNU thing, not POSIX?

> > syntax used (with two dashes) in 3.6.  The easiest way to detect
> 
> Is it worth it to check which version of gv is in use?

Probably not.

In general we've never tried to support old versions of software except
where the old version continues to be widely distributed (such as if
Solaris comes with an old version).

Any reason for removing gview from the commands it completes? Is that a
Gnome variant of gv? We probably should complete postscript files for
kghostview too.

Oliver

Re: Bug#303278: zsh: completions for gv are for pre 3.6

[Clint Adams]

> Aren't two dashes a GNU thing, not POSIX?

Yes.

> Probably not.

Okay, I'll commit it then.

> Any reason for removing gview from the commands it completes? Is that a
> Gnome variant of gv? We probably should complete postscript files for
> kghostview too.

Well, my gview is a symlink to vim.  We have the GNOME variant in
_gnome-gv.  I'll leave kghostview to someone who has it installed.