zsh-4_2-patches

zsh-4_2-patches

[Peter Stephenson]

I've ported the following changes to the 4.2 code line.  This is really
just bug fixes, including documentation improvements; I haven't
considered porting any enhancements.  We may be ready to make another
release there.  If you have any further suggestions, please let me know
by about this time on Monday.

Index: ChangeLog
===================================================================
RCS file: /cvsroot/zsh/zsh/ChangeLog,v
retrieving revision 1.2478.2.23
diff -u -u -r1.2478.2.23 ChangeLog
--- ChangeLog	31 Mar 2005 13:44:56 -0000	1.2478.2.23
+++ ChangeLog	1 Apr 2005 10:38:15 -0000
@@ -1,3 +1,8 @@
+2005-04-01  Peter Stephenson  <pws@csr.com>
+
+	* 21078: Src/init.c, Test/A01grammar.ztst: parse errors didn't
+	cause non-zero exit status.
+
 2005-03-27  Clint Adams  <clint@zsh.org>
 
 	* 21075: Completion/Unix/Command/_baz: update baz completion
@@ -15,11 +20,27 @@
 	* 21045: Src/Zle/compcore.c, Src/Zle/complete.c: more places
 	where completion didn't handled Meta characters.
 
+2005-03-21  Peter Stephenson  <pws@csr.com>
+
+	* 21042: Src/Zle/zle_main.c, Doc/Zsh/zle.yo: test for and
+	document limitation that execute-named-comand and
+	execute-last-named-command can't be redefined or called by name.
+
+2005-03-18  Peter Stephenson  <pws@csr.com>
+
+	* zsh-users/8609: Doc/Zsh/expn.yo: document order of (u), (o)
+	and (O) parameter expansion flags.
+
 2005-03-16  Peter Stephenson  <pws@csr.com>
 
 	* 20983: Test/D02glob.ztst, Src/glob.c: fixed string segments
 	in globbed paths could be copied wrongly, resulting in failed globs.
 
+2005-03-15  Peter Stephenson  <pws@csr.com>
+
+	* 20978: Src/zle_main.c: don't propagate EOFs from recursive
+	edit.
+
 2005-03-10  Peter Stephenson  <pws@csr.com>
 
 	* 20959 (variant of 20958): Src/params.c, Src/Module/parameter.c,
@@ -53,6 +74,10 @@
 	a single-character Makefile variable if it is a digit.  Avoids
 	an infinite recursion from a Makefile referencing $1.
 
+2005-02-28  Philippe Troin  <phil@fifi.org>
+
+	* 20886: configure.ac: Use TTOU with trap rather than SIGTTOU.
+
 2005-02-25  Oliver Kiddle  <opk@zsh.org>
 
 	* 20867: Completion/Unix/Command/_ant: handle imported files

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

**********************************************************************

Re: zsh-4_2-patches

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 01 April 2005 14:51, Peter Stephenson wrote:
> I've ported the following changes to the 4.2 code line.  This is really
> just bug fixes, including documentation improvements; I haven't
> considered porting any enhancements.  We may be ready to make another
> release there.  If you have any further suggestions, please let me know
> by about this time on Monday.
>

Zsh in current Mandrake (4.2.4) crashes when completing rsync. I can currently 
reproduce it by using the following (_rsync is from current CVS):

{pts/3}% zsh -f
localhost% autoload -U compinit; compinit
localhost% bindkey '^I' complete-word
localhost% zmodload zsh/complist
localhost% bindkey -M menuselect / accept-and-infer-next-history
localhost% setopt nolistambiguous
localhost% zstyle ':completion:*' menu select=0
localhost% zstyle ':completion:*:rsync:*' hosts ftp.uio.no ftp.sunet.se

Now start completion by using e.g.

rsync rsync://ftp.ioTAB

and continue pressing "/" (you need to select some from list) until you get to 
rsync://ftp.uio.no/fedora-linux-core/updates/1/i386 and display list of 
files.

Pressing cursor UP at this point crashes zsh.

- -andrey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCT9mFR6LMutpd94wRAiGEAJ9/FSUWbccwj51aJYLDaYscUWYzJgCgph+e
WDQQPiNLuYa2hnEr6KDW+hw=
=/f9u
-----END PGP SIGNATURE-----

Re: zsh-4_2-patches

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 03 April 2005 15:54, Andrey Borzenkov wrote:
> On Friday 01 April 2005 14:51, Peter Stephenson wrote:
> > I've ported the following changes to the 4.2 code line.  This is really
> > just bug fixes, including documentation improvements; I haven't
> > considered porting any enhancements.  We may be ready to make another
> > release there.  If you have any further suggestions, please let me know
> > by about this time on Monday.
>
> Zsh in current Mandrake (4.2.4) crashes when completing rsync. I can
> currently reproduce it by using the following (_rsync is from current CVS):
>
> {pts/3}% zsh -f
> localhost% autoload -U compinit; compinit
> localhost% bindkey '^I' complete-word
> localhost% zmodload zsh/complist
> localhost% bindkey -M menuselect / accept-and-infer-next-history
> localhost% setopt nolistambiguous
> localhost% zstyle ':completion:*' menu select=0
> localhost% zstyle ':completion:*:rsync:*' hosts ftp.uio.no ftp.sunet.se
>
> Now start completion by using e.g.
>
> rsync rsync://ftp.ioTAB
>
> and continue pressing "/" (you need to select some from list) until you get
> to rsync://ftp.uio.no/fedora-linux-core/updates/1/i386 and display list of
> files.
>
> Pressing cursor UP at this point crashes zsh.
>

it also crashes in current CVS

#0  0xb7c7bb78 in singledraw () at /home/bor/src/zsh/Src/Zle/complist.c:1564
#1  0xb7c7c68d in complistmatches (dummy=0xb7cc0ab0, dat=0xbfffea80)
    at /home/bor/src/zsh/Src/Zle/complist.c:1677
#2  0x080939c3 in runhookdef (h=0xb7cc0ab0, d=0xbfffea80)
    at /home/bor/src/zsh/Src/module.c:1865
#3  0xb7cbe3f3 in list_matches (dummy=0xb7cf2e40, dummy2=0x0)
    at /home/bor/src/zsh/Src/Zle/compresult.c:2173
#4  0x080939c3 in runhookdef (h=0xb7cf2e40, d=0x0)
    at /home/bor/src/zsh/Src/module.c:1865
#5  0xb7cdcd7c in zrefresh () at /home/bor/src/zsh/Src/Zle/zle_refresh.c:740
#6  0xb7c7db6d in domenuselect (dummy=0xb7cc0a74, dat=0xbfffee70)
    at /home/bor/src/zsh/Src/Zle/complist.c:2134
#7  0x08093963 in runhookdef (h=0xb7cc0a74, d=0xbfffee70)
    at /home/bor/src/zsh/Src/module.c:1859
#8  0xb7caa7e4 in after_complete (dummy=0xb7cf2e7c, dat=0xbfffef08)
    at /home/bor/src/zsh/Src/Zle/compcore.c:496
#9  0x080939c3 in runhookdef (h=0xb7cf2e7c, d=0xbfffef08)
    at /home/bor/src/zsh/Src/module.c:1865
#10 0xb7ce1af5 in docomplete (lst=0)
    at /home/bor/src/zsh/Src/Zle/zle_tricky.c:835
#11 0xb7ce0367 in completeword (args=0xb7cf30bc)
    at /home/bor/src/zsh/Src/Zle/zle_tricky.c:208
#12 0xb7ce0251 in completecall (args=0xb7cf30bc)
    at /home/bor/src/zsh/Src/Zle/zle_tricky.c:184
#13 0xb7cd4134 in execzlefunc (func=0xb7cf0fd0, args=0xb7cf30bc)
    at /home/bor/src/zsh/Src/Zle/zle_main.c:1053
#14 0xb7cd37b1 in zlecore () at /home/bor/src/zsh/Src/Zle/zle_main.c:828
#15 0xb7cd3e0e in zleread (lp=0x80dfe80, rp=0x0, flags=3, context=0)
    at /home/bor/src/zsh/Src/Zle/zle_main.c:982
#16 0x0807f241 in inputline () at /home/bor/src/zsh/Src/input.c:278
#17 0x0807f0f8 in ingetc () at /home/bor/src/zsh/Src/input.c:214
#18 0x0807642a in ihgetc () at /home/bor/src/zsh/Src/hist.c:240
#19 0x08086345 in gettok () at /home/bor/src/zsh/Src/lex.c:627
#20 0x08085bff in yylex () at /home/bor/src/zsh/Src/lex.c:343
#21 0x0809e152 in parse_event () at /home/bor/src/zsh/Src/parse.c:449
#22 0x0807c312 in loop (toplevel=1, justonce=0)
    at /home/bor/src/zsh/Src/init.c:128
#23 0x0807ed51 in zsh_main (argc=2, argv=0xbffff374)
    at /home/bor/src/zsh/Src/init.c:1284
#24 0x08052696 in main (argc=2, argv=0xbffff374)
    at /home/bor/src/zsh/Src/main.c:93

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCT/WLR6LMutpd94wRAuAeAJ9xvE2j1i665xC+mjziGi28HEckXQCcCao4
h1eaZZFNs/mdY1i2rr2M7ls=
=cJ64
-----END PGP SIGNATURE-----

Re: zsh-4_2-patches

[Peter Stephenson]

Andrey Borzenkov wrote:
> > Zsh in current Mandrake (4.2.4) crashes when completing rsync. I can
> > currently reproduce it by using the following (_rsync is from current CVS):
> 
> it also crashes in current CVS

It doesn't look like I'm going to be able to jump through enough hoops
to be able to reproduce the problem in this form.

Is this only on the zsh-4_2-patches branch?  Can you reproduce it by
completing with the same list of files recreated locally?  From the line
number, it looks like the error is probably that the variable "g" is
NULL, hence mgtab[ml2 * columns * mc2] is NULL?

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

**********************************************************************

Re: zsh-4_2-patches

[Andrey Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 3276 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 06 April 2005 14:49, Peter Stephenson wrote:
> Andrey Borzenkov wrote:
> > > Zsh in current Mandrake (4.2.4) crashes when completing rsync. I can
> > > currently reproduce it by using the following (_rsync is from current
> > > CVS):
> >
> > it also crashes in current CVS
>
> It doesn't look like I'm going to be able to jump through enough hoops
> to be able to reproduce the problem in this form.
>
> Is this only on the zsh-4_2-patches branch? 

No. It segfaults just as nicely in current CVS.

> Can you reproduce it by 
> completing with the same list of files recreated locally? 

yes. Using attached "foo" and "list" - drop them in current directory and do

pts/3}% ~/pkg/bin/zsh -f
localhost% autoload -U compinit; compinit
localhost% setopt nolistambiguous
localhost% zstyle ':completion:*' menu select=0
localhost% source foo; compdef _foo foo
localhost% foo xxx/<TAB>
zsh: do you wish to see all 276 possibilities (306 lines)?

press "y", press TAB, press any cursor key - zsh segfaults 

Several times it also aborted with the message

*** glibc detected *** corrupted double-linked list: 0x08190db0 ***

(glibc 2.3.4 on Mandrake 10.2). I was not able to reliably reproduce it. 
Sometimes it does not crash immediately but usually does it anyway later.

> From the line 
> number, it looks like the error is probably that the variable "g" is
> NULL, hence mgtab[ml2 * columns * mc2] is NULL?

1563        g = mgtab[ml1 * columns + mc1];
1564        clprintm(g, mtab[ml1 * columns + mc1], mcc1, ml1, lc1,
1565                 (g->widths ? g->widths[mcc1] : g->width));
1566        putc('\r', shout);

(gdb) print g
$4 = 0x8183c20
(gdb) print mtab
$5 = (Cmatch **) 0x8191748
(gdb) print mtab[ml1*columns + mc1]
$6 = (Cmatch *) 0x81837e0
(gdb) print mcc1
$8 = 0
(gdb) print ml1
$9 = 0
(gdb) print lc1
$10 = 1
(gdb) print g->widths[mcc1]
Cannot access memory at address 0x31322033
(gdb) print g->widths
$11 = (int *) 0x31322033
(gdb) print *g
$12 = {name = 0x818ec00 "`�030\b\220�030\b�\030\b", prev = 0x818ed30,
  next = 0x818ee08, flags = 135851744, mcount = 0, matches = 0x19,
  lcount = 135383392, llcount = 135773768, ylist = 0x818efd8, ecount = 0,
  expls = 0x18, ccount = 16, lexpls = 0x656c6966, lmatches = 0x73,
  lfmatches = 0x0, lallccs = 0x59, num = 762802733, nbrbeg = 1915563378,
  nbrend = 538979629, new = 538976288, dcount = 892744243, cols = 840972086,
  lins = 791949360, width = 825176624, widths = 0x31322033, totl = 976237114,
  shortest = 1478506803, perm = 0x65657246}
(gdb) print **mtab[ml1*columns + mc1]
$16 = {str = 0x81155a8 "freeradius-mysql-0.9.3-1.1.i386.rpm",
  orig = 0x810ff38 "freeradius-mysql-0.9.3-1.1.i386.rpm",
  ipre = 0x810fcc8 "xxx/", ripre = 0x0, isuf = 0x0, ppre = 0x0, psuf = 0x0,
  prpre = 0x0, pre = 0x0, suf = 0x0,
  disp = 0x8161038 "-rw-r--r--        7958 2004/02/16 19:22:27 
freeradius-mysql-0.9.3-1.1.i386.rpm", autoq = 0x0, flags = 0, brpl = 0x0, 
brsl = 0x0,
  rems = 0x0, remf = 0x0, qipl = 0, qisl = 0, rnum = 1, gnum = 1, mode = 0,
  modec = 0 '\0'}



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCVW/bR6LMutpd94wRArvKAJ9ddoU0yh+oIkdlLmHg1O2doHERgQCgh5bf
t2LVVleTfXMaao31RtuuXCg=
=y4Pf
-----END PGP SIGNATURE-----

[-- Attachment #2: comptest.tar.gz --]
[-- Type: application/x-tgz, Size: 5218 bytes --]