From: Doug Kearns <dougkearns@gmail.com>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: expl not always local
Date: Mon, 6 Jun 2005 23:33:50 +1000 [thread overview]
Message-ID: <20050606133349.GC16824@localhost.localdomain> (raw)
In-Reply-To: <1050602170247.ZM12815@candle.brasslantern.com>
On Thu, Jun 02, 2005 at 05:02:47PM +0000, Bart Schaefer wrote:
> On Jun 2, 6:44pm, Oliver Kiddle wrote:
> } Subject: Re: PATCH: expl not always local
> }
> } Bart wrote:
> } > Careful with these. They may be expecting to be called in a context
> } > where the caller has declared expl as a local.
> } >
> } > In general, if a function file starts with #autload then it's a
> } > utility and should NOT declare completion system variables as locals,
> }
> } I disagree. The only way we should be passing stuff to #autoload (Type/)
> } functions is with the positional parameters.
>
> I agree with your "should" but I don't believe that it's presently the
> case that all completion functions work that way. Blindly adding a lot
> of "local" declarations without investigating the calling contexts is
> a road to mysterious future breakage.
I might be missing something, but isn't leaving these few exceptions
only encouraging future completion functions to rely on the incorrect
behaviour?
<snip>
Regards,
Doug
next prev parent reply other threads:[~2005-06-06 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-02 13:25 Doug Kearns
2005-06-02 15:28 ` Bart Schaefer
2005-06-02 16:44 ` Oliver Kiddle
2005-06-02 17:02 ` Bart Schaefer
2005-06-06 13:33 ` Doug Kearns [this message]
2005-06-06 16:24 ` Bart Schaefer
2005-06-06 17:26 ` Oliver Kiddle
2005-06-07 14:38 ` Oliver Kiddle
2005-06-06 13:33 ` Doug Kearns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050606133349.GC16824@localhost.localdomain \
--to=dougkearns@gmail.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).