From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15593 invoked from network); 6 Jun 2005 13:40:25 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 6 Jun 2005 13:40:25 -0000 Received: (qmail 66387 invoked from network); 6 Jun 2005 13:40:14 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 6 Jun 2005 13:40:14 -0000 Received: (qmail 26049 invoked by alias); 6 Jun 2005 13:40:12 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21308 Received: (qmail 26039 invoked from network); 6 Jun 2005 13:40:12 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 6 Jun 2005 13:40:12 -0000 Received: (qmail 66083 invoked from network); 6 Jun 2005 13:40:12 -0000 Received: from grunt22.ihug.com.au (203.109.249.142) by a.mx.sunsite.dk with SMTP; 6 Jun 2005 13:40:08 -0000 Received: from 203-173-24-138.dyn.iinet.net.au (localhost.localdomain) [203.173.24.138] by grunt22.ihug.com.au with esmtp (Exim 3.35 #1 (Debian)) id 1DfHpb-0001Qc-00; Mon, 06 Jun 2005 23:40:03 +1000 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.12.8/8.12.8) with ESMTP id j56DY0T0015798 for ; Mon, 6 Jun 2005 23:34:16 +1000 Received: (from doug@localhost) by localhost.localdomain (8.12.8/8.12.8/Submit) id j56DXoNv015790 for zsh-workers@sunsite.dk; Mon, 6 Jun 2005 23:33:50 +1000 X-Authentication-Warning: localhost.localdomain: doug set sender to dougkearns@gmail.com using -f Date: Mon, 6 Jun 2005 23:33:50 +1000 From: Doug Kearns To: zsh-workers@sunsite.dk Subject: Re: PATCH: expl not always local Message-ID: <20050606133349.GC16824@localhost.localdomain> Mail-Followup-To: zsh-workers@sunsite.dk References: <20050602132519.GA10266@localhost.localdomain> <1050602152831.ZM12324@candle.brasslantern.com> <2817.1117730651@trentino.groupinfra.com> <1050602170247.ZM12815@candle.brasslantern.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1050602170247.ZM12815@candle.brasslantern.com> User-Agent: Mutt/1.4i X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=BAYES_00,RCVD_IN_SORBS_WEB autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 On Thu, Jun 02, 2005 at 05:02:47PM +0000, Bart Schaefer wrote: > On Jun 2, 6:44pm, Oliver Kiddle wrote: > } Subject: Re: PATCH: expl not always local > } > } Bart wrote: > } > Careful with these. They may be expecting to be called in a context > } > where the caller has declared expl as a local. > } > > } > In general, if a function file starts with #autload then it's a > } > utility and should NOT declare completion system variables as locals, > } > } I disagree. The only way we should be passing stuff to #autoload (Type/) > } functions is with the positional parameters. > > I agree with your "should" but I don't believe that it's presently the > case that all completion functions work that way. Blindly adding a lot > of "local" declarations without investigating the calling contexts is > a road to mysterious future breakage. I might be missing something, but isn't leaving these few exceptions only encouraging future completion functions to rely on the incorrect behaviour? Regards, Doug