From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15793 invoked from network); 15 Jul 2005 07:01:20 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 15 Jul 2005 07:01:20 -0000 Received: (qmail 36263 invoked from network); 15 Jul 2005 07:01:12 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 15 Jul 2005 07:01:12 -0000 Received: (qmail 28107 invoked by alias); 15 Jul 2005 07:01:09 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21471 Received: (qmail 28097 invoked from network); 15 Jul 2005 07:01:08 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 15 Jul 2005 07:01:08 -0000 Received: (qmail 35997 invoked from network); 15 Jul 2005 07:01:08 -0000 Received: from master.altlinux.ru (HELO master.altlinux.org) (62.118.250.235) by a.mx.sunsite.dk with SMTP; 15 Jul 2005 07:01:02 -0000 Received: from solemn.turbinal.org (localhost.localdomain [127.0.0.1]) by master.altlinux.org (Postfix) with ESMTP id A7636E5EE1 for ; Fri, 15 Jul 2005 11:01:01 +0400 (MSD) Received: by solemn.turbinal.org (Postfix, from userid 500) id 69DC978679; Fri, 15 Jul 2005 10:59:56 +0400 (MSD) Date: Fri, 15 Jul 2005 10:59:56 +0400 From: Alexey Tourbin To: zsh-workers@sunsite.dk Subject: zsh/files.so: `mkdir -p' fails on symlinks Message-ID: <20050715065955.GK3337@solemn.turbinal.org> Mail-Followup-To: zsh-workers@sunsite.dk Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UK1lfQXsnwKrySH9" Content-Disposition: inline X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 --UK1lfQXsnwKrySH9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, I've got a bug report on built-in mkdir command: https://bugzilla.altlinux.org/show_bug.cgi?id=3D7368 $ mkdir dir $ mkdir dir/subdir $ ln -s dir dirp $ zmodload zsh/files $ which mkdir mkdir: shell built-in command $ mkdir -p dirp/subdir/subdir2 mkdir: cannot make directory `dirp': file exists $ /bin/mkdir -p dirp/subdir/subdir2 $ Proposed fix is as follows: --- zsh-4.3.0-20050712/Src/Modules/files.c- 2004-10-19 19:09:50 +0000 +++ zsh-4.3.0-20050712/Src/Modules/files.c 2005-07-15 06:55:52 +0000 @@ -127,7 +127,7 @@ domkdir(char *nam, char *path, mode_t mo if(p) { struct stat st; =20 - if(!lstat(rpath, &st) && S_ISDIR(st.st_mode)) + if(!stat(rpath, &st) && S_ISDIR(st.st_mode)) return 0; } oumask =3D umask(0); End of patch --=20 Alexey Tourbin ALT Linux Team --UK1lfQXsnwKrySH9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFC117rfBKgtDjnu0YRAnIJAKC7gQi9Wt5YrJWUtxm5DemO/XOtKACguKQo P9V53+O03EGOK2vV5UxdCYQ= =EQxP -----END PGP SIGNATURE----- --UK1lfQXsnwKrySH9--