zsh-workers
 help / color / mirror / code / Atom feed
From: Wayne Davison <wayned@users.sourceforge.net>
To: zsh-workers@sunsite.dk
Subject: PATCH: _rsync improved
Date: Fri, 29 Jul 2005 12:31:24 -0700	[thread overview]
Message-ID: <20050729193124.GC26009@blorf.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

I reorderd some lines in the _rsync completion function to work around
a previously-reported problem with shorter options interfereing with
the completion of longer options.  [To remind folks what was wrong: the
options --include-from and --exclude-from were not completing files
after an '=' (though they would complete files if the '=' was removed)
because each had a shorter option (--include and --exclude) that also
ended with a '='.]

I just discovered that if I moved each longer option to come before
the associated shorter option, that file completion starts to work
properly.  At some point we'll probably want to debug this so that
the order is not significant.

..wayne..

[-- Attachment #2: rsync.patch --]
[-- Type: text/plain, Size: 972 bytes --]

--- _rsync	27 Apr 2005 08:22:34 -0000	1.24
+++ _rsync	29 Jul 2005 19:18:01 -0000
@@ -166,10 +166,10 @@ _arguments -s \
   '(-C --cvs-exclude)'{-C,--cvs-exclude}'[auto-ignore files the same way CVS does]' \
   '*'{-f,--filter=}'[add a file-filtering rule]:rule:' \
   '*-F[same as --filter="dir-merge /.rsync-filter", repeated: --filter="- .rsync-filter"]' \
-  '*--exclude=[exclude files matching pattern]:pattern:' \
   '--exclude-from=[read exclude patterns from specified file]:file:_files' \
-  '*--include=[do not exclude files matching pattern]:pattern:' \
+  '*--exclude=[exclude files matching pattern]:pattern:' \
   '--include-from=[read include patterns from specified file]:file:_files' \
+  '*--include=[do not exclude files matching pattern]:pattern:' \
   '--files-from=[read list of source-file names from specified file]:file:_files' \
   '(-0 --from0)'{-0,--from0}'[all *-from file lists are delimited by nulls]' \
   '--version[print version number]' \

                 reply	other threads:[~2005-07-29 19:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050729193124.GC26009@blorf.net \
    --to=wayned@users.sourceforge.net \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).