From: Wayne Davison <wayned@users.sourceforge.net>
To: Thorsten Dahlheimer <tdahlheim@gmx.net>
Cc: zsh-workers@sunsite.dk
Subject: Re: PATCH: Slightly improve test harness
Date: Tue, 9 Aug 2005 00:39:27 -0700 [thread overview]
Message-ID: <20050809073927.GC12952@blorf.net> (raw)
In-Reply-To: <028601c59c46$56d0dea0$cc74fea9@pcdahl4201>
On Mon, Aug 08, 2005 at 08:23:54PM +0200, Thorsten Dahlheimer wrote:
> - don't abort the test run if a testcase fails (unless there's a syntax
> error in the test file)
That change results in an erroneous "Test successful" message when a
test fails and verbosity is at least 1. Did you check if any of the
test cases expected the success of an earlier test in a later test?
If so, it might be best to just leave the abort-after-the-first-failure
behavior unchanged.
> - make sure cleanup is always performed when exiting
That fixed trap code seems to make it impossible to Ctrl-C out of the
tests, though I'm not sure why yet. Perhaps it's a bug in trap
handling, but zsh hangs when that cleanup trap in place and Ctrl-C is
pressed.
In the meantime, I've checked in a change that just disables the trap
line (since zsh now complains about its incorrect syntax).
..wayne..
next prev parent reply other threads:[~2005-08-09 7:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-08 18:23 Thorsten Dahlheimer
2005-08-09 7:39 ` Wayne Davison [this message]
2005-08-15 16:02 ` Thorsten Dahlheimer
2005-08-11 15:45 ` Bart Schaefer
2005-08-15 16:02 ` Thorsten Dahlheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050809073927.GC12952@blorf.net \
--to=wayned@users.sourceforge.net \
--cc=tdahlheim@gmx.net \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).