From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27941 invoked from network); 9 Aug 2005 07:39:42 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 9 Aug 2005 07:39:42 -0000 Received: (qmail 38262 invoked from network); 9 Aug 2005 07:39:36 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 9 Aug 2005 07:39:36 -0000 Received: (qmail 19660 invoked by alias); 9 Aug 2005 07:39:33 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21586 Received: (qmail 19651 invoked from network); 9 Aug 2005 07:39:33 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 9 Aug 2005 07:39:33 -0000 Received: (qmail 37946 invoked from network); 9 Aug 2005 07:39:33 -0000 Received: from dsl3-63-249-88-2.cruzio.com (HELO dot.blorf.net) (63.249.88.2) by a.mx.sunsite.dk with SMTP; 9 Aug 2005 07:39:28 -0000 Received: by dot.blorf.net (Postfix, from userid 1000) id 7B5F793C; Tue, 9 Aug 2005 00:39:27 -0700 (PDT) Date: Tue, 9 Aug 2005 00:39:27 -0700 From: Wayne Davison To: Thorsten Dahlheimer Cc: zsh-workers@sunsite.dk Subject: Re: PATCH: Slightly improve test harness Message-ID: <20050809073927.GC12952@blorf.net> References: <028601c59c46$56d0dea0$cc74fea9@pcdahl4201> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <028601c59c46$56d0dea0$cc74fea9@pcdahl4201> User-Agent: Mutt/1.5.9i X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.4 On Mon, Aug 08, 2005 at 08:23:54PM +0200, Thorsten Dahlheimer wrote: > - don't abort the test run if a testcase fails (unless there's a syntax > error in the test file) That change results in an erroneous "Test successful" message when a test fails and verbosity is at least 1. Did you check if any of the test cases expected the success of an earlier test in a later test? If so, it might be best to just leave the abort-after-the-first-failure behavior unchanged. > - make sure cleanup is always performed when exiting That fixed trap code seems to make it impossible to Ctrl-C out of the tests, though I'm not sure why yet. Perhaps it's a bug in trap handling, but zsh hangs when that cleanup trap in place and Ctrl-C is pressed. In the meantime, I've checked in a change that just disables the trap line (since zsh now complains about its incorrect syntax). ..wayne..