zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: PATCH: fix 1, was Re: unpatch: metafying zle line
Date: Wed, 10 Aug 2005 12:57:52 +0100	[thread overview]
Message-ID: <200508101157.j7ABvrck017869@news01.csr.com> (raw)
In-Reply-To: <200508101034.j7AAYISV013947@news01.csr.com>

Peter Stephenson wrote:
> I have a patch for the first step in making completion work with wide
> characters.  It's quite long, so instead of posting a patch which will
> fill people's mailboxes and no one will read I'll describe it here and
> commit it some time during the day.

It's committed.  Here's the first bug: accept-and-infer-next-history in
menu selection gets the metafication state confused.  (That function is
probably the most confused with regard to the state, see the comment
further up.)

Index: Src/Zle/complist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/complist.c,v
retrieving revision 1.69
diff -u -r1.69 complist.c
--- Src/Zle/complist.c	10 Aug 2005 10:56:41 -0000	1.69
+++ Src/Zle/complist.c	10 Aug 2005 11:55:11 -0000
@@ -2303,7 +2303,10 @@
                 iforcemenu = -1;
             } else
                 mode = 0;
+	    /* Nested completion assumes line is unmetafied */
+	    unmetafy_line();
 	    menucomplete(zlenoargs);
+	    metafy_line();
 	    iforcemenu = 0;
 
             if (cmd != Th(z_acceptandinfernexthistory))

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

**********************************************************************


  parent reply	other threads:[~2005-08-10 11:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-10 10:34 Peter Stephenson
2005-08-10 11:31 ` DervishD
2005-08-10 11:57 ` Peter Stephenson [this message]
2005-08-10 13:19   ` PATCH: fix 2, was " Peter Stephenson
2005-08-10 19:53     ` PATCH: fix 3, " Peter Stephenson
2005-08-10 14:04 ` David Gómez
2005-08-10 17:34 ` David Gómez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200508101157.j7ABvrck017869@news01.csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).