zsh-workers
 help / color / mirror / code / Atom feed
From: Wayne Davison <wayned@users.sourceforge.net>
To: Andrey Borzenkov <arvidjaar@newmail.ru>
Cc: zsh-workers@sunsite.dk
Subject: Re: crash in completing code with unicode support
Date: Tue, 16 Aug 2005 14:37:13 -0700	[thread overview]
Message-ID: <20050816213713.GA5904@blorf.net> (raw)
In-Reply-To: <200508162327.58597.arvidjaar@newmail.ru>

On Tue, Aug 16, 2005 at 11:27:49PM +0400, Andrey Borzenkov wrote:
>                     p = compprefix + 1;
>                     if (*p == Meta)
>                         p += 2;

I haven't tried to fully grok that code yet, but it looks to me like the
non-meta case results in just the character at compprefix being sent to
pattry(), so shouldn't the code really be checking if the compprefix
character is metified or not?

    p = compprefix + 1 + (*compprefix == Meta);

Also, the following check (from slightly lower down) needs to be changed
to handle the potential for the pointer to be bumped further forward:

    if (p == compprefix + l)

If the above is right, then this line should probably be changed to be:

    if (p == compprefix + l + (*compprefix == Meta))

..wayne..


  reply	other threads:[~2005-08-16 21:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-16  1:37 Mikael Magnusson
2005-08-16  7:57 ` Andrey Borzenkov
2005-08-16 11:44   ` Clint Adams
2005-08-16 12:09     ` Nikolai Weibull
2005-08-16 16:16       ` Andrey Borzenkov
2005-08-18  9:34         ` Peter Stephenson
2005-08-16 12:01   ` Mikael Magnusson
2005-08-16 19:27     ` Andrey Borzenkov
2005-08-16 21:37       ` Wayne Davison [this message]
2005-08-16 21:49         ` Wayne Davison
2005-08-17  0:22           ` crash fixed, other minor issue though was: " Mikael Magnusson
2005-08-18 16:48             ` Andrey Borzenkov
2005-08-18 16:35           ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050816213713.GA5904@blorf.net \
    --to=wayned@users.sourceforge.net \
    --cc=arvidjaar@newmail.ru \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).