From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-21644-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 4499 invoked from network); 16 Aug 2005 21:37:28 -0000
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by ns1.primenet.com.au with SMTP; 16 Aug 2005 21:37:28 -0000
Received: (qmail 5038 invoked from network); 16 Aug 2005 21:37:22 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 16 Aug 2005 21:37:22 -0000
Received: (qmail 20537 invoked by alias); 16 Aug 2005 21:37:19 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 21644
Received: (qmail 20528 invoked from network); 16 Aug 2005 21:37:19 -0000
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by sunsite.dk with SMTP; 16 Aug 2005 21:37:19 -0000
Received: (qmail 4775 invoked from network); 16 Aug 2005 21:37:18 -0000
Received: from dsl3-63-249-88-2.cruzio.com (HELO dot.blorf.net) (63.249.88.2)
  by a.mx.sunsite.dk with SMTP; 16 Aug 2005 21:37:14 -0000
Received: by dot.blorf.net (Postfix, from userid 1000)
	id BA08F7A8; Tue, 16 Aug 2005 14:37:13 -0700 (PDT)
Date: Tue, 16 Aug 2005 14:37:13 -0700
From: Wayne Davison <wayned@users.sourceforge.net>
To: Andrey Borzenkov <arvidjaar@newmail.ru>
Cc: zsh-workers@sunsite.dk
Subject: Re: crash in completing code with unicode support
Message-ID: <20050816213713.GA5904@blorf.net>
References: <237967ef05081518376385563e@mail.gmail.com> <200508161157.59407.arvidjaar@newmail.ru> <237967ef050816050130fefbf8@mail.gmail.com> <200508162327.58597.arvidjaar@newmail.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200508162327.58597.arvidjaar@newmail.ru>
User-Agent: Mutt/1.5.9i
X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham 
	version=3.0.4

On Tue, Aug 16, 2005 at 11:27:49PM +0400, Andrey Borzenkov wrote:
>                     p = compprefix + 1;
>                     if (*p == Meta)
>                         p += 2;

I haven't tried to fully grok that code yet, but it looks to me like the
non-meta case results in just the character at compprefix being sent to
pattry(), so shouldn't the code really be checking if the compprefix
character is metified or not?

    p = compprefix + 1 + (*compprefix == Meta);

Also, the following check (from slightly lower down) needs to be changed
to handle the potential for the pointer to be bumped further forward:

    if (p == compprefix + l)

If the above is right, then this line should probably be changed to be:

    if (p == compprefix + l + (*compprefix == Meta))

..wayne..