From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28958 invoked from network); 9 Sep 2005 13:49:01 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 9 Sep 2005 13:49:01 -0000 Received: (qmail 10214 invoked from network); 9 Sep 2005 13:48:56 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 9 Sep 2005 13:48:56 -0000 Received: (qmail 13760 invoked by alias); 9 Sep 2005 13:48:53 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21718 Received: (qmail 13746 invoked from network); 9 Sep 2005 13:48:52 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 9 Sep 2005 13:48:52 -0000 Received: (qmail 9857 invoked from network); 9 Sep 2005 13:48:52 -0000 Received: from acolyte.scowler.net (216.254.112.45) by a.mx.sunsite.dk with SMTP; 9 Sep 2005 13:48:47 -0000 Received: by acolyte.scowler.net (Postfix, from userid 1000) id 3AF9770055; Fri, 9 Sep 2005 09:48:46 -0400 (EDT) Date: Fri, 9 Sep 2005 09:48:46 -0400 From: Clint Adams To: zsh-workers@sunsite.dk Subject: Re: PATCH: _bzr Message-ID: <20050909134846.GA22966@scowler.net> Mail-Followup-To: zsh-workers@sunsite.dk References: <20050906160630.GA10503@scowler.net> <5740.1126261568@trentino.groupinfra.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5740.1126261568@trentino.groupinfra.com> User-Agent: Mutt/1.5.9i X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.4 > If you are going to leave a part missing like that, it probably makes > sense to complete files there. Unless bzr never takes filenames as an > argument. Breaking filename completion is really quite bad because it > can put users off compsys completely. Done, with clarification. Index: Completion/Unix/Command/_bzr =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_bzr,v retrieving revision 1.1 diff -u -r1.1 _bzr --- Completion/Unix/Command/_bzr 6 Sep 2005 16:08:29 -0000 1.1 +++ Completion/Unix/Command/_bzr 9 Sep 2005 13:47:52 -0000 @@ -7,5 +7,7 @@ if (( CURRENT == 2 )); then _describe -t subcommand 'subcommand' _bzr_subcommands else -# this part missing +# this part should call bzr shell-complete when +# it has been tweaked properly + _files fi