zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: zsh 4.2.5 compile problem on AIX
Date: Fri, 9 Sep 2005 15:50:55 +0100	[thread overview]
Message-ID: <20050909155055.12408b26.pws@csr.com> (raw)
In-Reply-To: <43218EAE.5060009@davidfavor.com>

David Favor <david@davidfavor.com> wrote:
> I've built many version of zsh for AIX including 4.2.0
> which I'm currently running. This appears to be a new
> problem.
> 
> Building zsh-4.2.5 on AIX 5100-08 the following shows up:
> 
>     gmake[2]: Entering directory `/data/build/work/zsh-4.2.5/Src/Zle'
>     rm -f complete.so
>     xlc_r -s -bM:SRE -o complete.so -bI:zle.export -bI:../../Src/zsh.export \
>        -bE:complete.export -emodentry complete..o compcore..o compmatch..o \
>        compresult..o  ../../Src/modentry..o  -L/usr/local/lib -lpcre -liconv \
>        -ldl -lcurses -lm  -lc
>     ld: 0711-317 ERROR: Undefined symbol: nullstrsetfn

Thanks for spotting this:  there is a perennial problem with AIX which is
particularly finnicky about the declaration of symbols used in a library.
There's a script Util/check_exports which I should run before making a
release.  Here's a fix for 4.2; I'll commit the change for 4.3 directly.

Index: Src/builtin.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/builtin.c,v
retrieving revision 1.133.2.1
diff -u -r1.133.2.1 builtin.c
--- Src/builtin.c	25 Apr 2005 10:40:54 -0000	1.133.2.1
+++ Src/builtin.c	9 Sep 2005 14:47:27 -0000
@@ -4041,7 +4041,7 @@
 
 /* Flag that we should exit the shell as soon as all functions return. */
 /**/
-int
+mod_export int
 exit_pending;
 
 /* break, bye, continue, exit, logout, return -- most of these take   *
Index: Src/params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/params.c,v
retrieving revision 1.94.2.3
diff -u -r1.94.2.3 params.c
--- Src/params.c	6 Sep 2005 15:28:40 -0000	1.94.2.3
+++ Src/params.c	9 Sep 2005 14:47:28 -0000
@@ -2608,7 +2608,7 @@
  */
 
 /**/
-void
+mod_export void
 nullstrsetfn(UNUSED(Param pm), char *x)
 {
     zsfree(x);


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

**********************************************************************


      reply	other threads:[~2005-09-09 14:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-09 13:31 David Favor
2005-09-09 14:50 ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050909155055.12408b26.pws@csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).