zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: PATCH: unmetacheck revisited
Date: Wed, 26 Oct 2005 10:59:18 +0100	[thread overview]
Message-ID: <200510260959.j9Q9xISV018878@news01.csr.com> (raw)

I was too pessimistic about the check for an unmetafied line on a call
to zle: the case I was really worried about was an otherwise successful
call to a widget.  Otherwise you can get unnecessary warnings with
a redisplay etc.

Index: Src/Zle/zle_thingy.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_thingy.c,v
retrieving revision 1.20
diff -u -r1.20 zle_thingy.c
--- Src/Zle/zle_thingy.c	23 Oct 2005 17:43:00 -0000	1.20
+++ Src/Zle/zle_thingy.c	26 Oct 2005 09:57:03 -0000
@@ -358,8 +358,6 @@
     struct opn const *op, *opp;
     int n;
 
-    UNMETACHECK();
-
     /* select operation and ensure no clashing arguments */
     for(op = opns; op->o && !OPT_ISSET(ops,STOUC(op->o)); op++) ;
     if(op->o)
@@ -659,6 +657,8 @@
 	return 1;
     }
 
+    UNMETACHECK();
+
     while (*args && **args == '-') {
 	char *num;
 	if (!args[0][1] || args[0][1] == '-') {

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


This message has been scanned for viruses by BlackSpider MailControl - www.blackspider.com


                 reply	other threads:[~2005-10-26  9:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200510260959.j9Q9xISV018878@news01.csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).