From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: changing ZLE_CHAR_T?
Date: Sat, 29 Oct 2005 10:59:00 +0100 [thread overview]
Message-ID: <200510290959.j9T9x0aI003876@pwslaptop.csr.com> (raw)
In-Reply-To: Your message of "Fri, 28 Oct 2005 15:58:41 PDT." <20051028225841.GC27510@blorf.net>
Wayne Davison wrote:
> One thing I don't like about the current definition of ZLE_CHAR_T is
> that, in the non-multibyte code, you don't end up with a ZLE_STRING_T
> if you take the address of a ZLE_CHAR_T variable (due to ZLE_CHAR_T
> being an "int" and ZLE_STRING_T being an "unsigned char *"). Since
> we have a ZLE_INT_T for those variables that need to be able to hold
> a ZLEEOF value, I thought it would be cleaner to change ZLE_CHAR_T.
This is potentially a good idea, but you will need to be careful since
those "int" definitions for the variables now marked as ZLE_CHAR_T have
been around a very long time and it's not necessarily clear if they will
hold an EOF or not, though if they do they should certainly now be
ZLE_INT_T. The distinction is quite recent and not necessarily
consistently applied throughout.
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page still at http://www.pwstephenson.fsnet.co.uk/
next prev parent reply other threads:[~2005-10-29 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-28 22:58 Wayne Davison
2005-10-29 9:59 ` Peter Stephenson [this message]
2005-10-31 21:45 ` Wayne Davison
2005-11-01 4:31 ` Wayne Davison
2005-11-01 10:20 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510290959.j9T9x0aI003876@pwslaptop.csr.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).