From: Wayne Davison <wayned@users.sourceforge.net>
To: Peter Stephenson <pws@csr.com>
Cc: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: PATCH: fixing ${1+"$@"} when word-splitting
Date: Mon, 13 Feb 2006 11:00:01 -0800 [thread overview]
Message-ID: <20060213190001.GD6952@dot.blorf.net> (raw)
In-Reply-To: <EXCHANGE0361Bp2fk8L0000c976@exchange03.csr.com>
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
On Mon, Feb 13, 2006 at 06:08:57PM +0000, Peter Stephenson wrote:
> unfortunately the saga continues...
:-) Yup. Thanks for the extensive testing!
> % fn() { local IFS=.-; print -l ${=1:-$ZSH_VERSION}; }
> % fn
> 4.3.0-dev-3
The attached patch fixes this by temporarily setting SHWORDSPLIT
during the multsub() call when '=' was specified. I also tested
that this change works properly with ${=1:-"$ZSH_VERSION"} (i.e.
giving the output above).
..wayne..
[-- Attachment #2: more-splitting.diff --]
[-- Type: text/plain, Size: 696 bytes --]
--- subst.c 2006-02-13 09:53:12.000000000 -0800
+++ subst.c 2006-02-13 10:50:52.000000000 -0800
@@ -2040,6 +2040,7 @@
/* Fall Through! */
case '-':
if (vunset) {
+ int ws = opts[SHWORDSPLIT];
val = dupstring(s);
/* If word-splitting is enabled, we ask multsub() to split
* the substituted string at unquoted whitespace. Then, we
@@ -2048,7 +2049,9 @@
* keep its array splits, and weird constructs such as
* ${str+"one two" "3 2 1" foo "$str"} to only be split
* at the unquoted spaces. */
+ opts[SHWORDSPLIT] = spbreak;
multsub(&val, spbreak && !aspar, (aspar ? NULL : &aval), &isarr, NULL);
+ opts[SHWORDSPLIT] = ws;
copied = 1;
spbreak = 0;
}
next prev parent reply other threads:[~2006-02-13 19:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-09 23:32 Libtool/zsh quoting problem David Gómez
2006-02-10 8:46 ` DervishD
2006-02-10 9:48 ` David Gómez
2006-02-10 11:34 ` DervishD
2006-02-10 12:56 ` David Gómez
2006-02-10 14:25 ` DervishD
2006-02-10 18:27 ` David Gómez
2006-02-10 19:31 ` DervishD
2006-02-11 9:36 ` [SOLVED] Libtool/zsh quoting problem: a zsh... bug? DervishD
2006-02-11 10:21 ` Andrey Borzenkov
2006-02-11 11:06 ` DervishD
2006-02-11 11:33 ` David Gómez
2006-02-11 12:06 ` DervishD
2006-02-11 12:28 ` Andrey Borzenkov
2006-02-11 18:07 ` DervishD
2006-02-11 12:21 ` DervishD
2006-02-11 18:14 ` Wayne Davison
2006-02-11 18:22 ` DervishD
2006-02-11 18:58 ` Wayne Davison
2006-02-11 19:42 ` Bart Schaefer
2006-02-12 4:50 ` Wayne Davison
2006-02-12 20:28 ` Peter Stephenson
2006-02-13 10:56 ` Peter Stephenson
2006-02-12 7:46 ` Andrey Borzenkov
2006-02-12 7:54 ` Andrey Borzenkov
2006-02-12 20:26 ` Peter Stephenson
2006-02-13 10:53 ` PATCH: fixing ${1+"$@"} when word-splitting Wayne Davison
2006-02-13 11:34 ` Peter Stephenson
2006-02-13 17:43 ` Wayne Davison
2006-02-13 18:08 ` Peter Stephenson
2006-02-13 19:00 ` Wayne Davison [this message]
2006-02-13 19:33 ` Wayne Davison
2006-02-13 19:33 ` Peter Stephenson
2006-02-13 20:11 ` Wayne Davison
2006-02-13 19:48 ` Wayne Davison
2006-02-13 11:40 ` DervishD
2006-02-14 7:14 ` Wayne Davison
2006-02-15 10:31 ` Wayne Davison
2006-02-15 11:35 ` Wayne Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060213190001.GD6952@dot.blorf.net \
--to=wayned@users.sourceforge.net \
--cc=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).