From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15937 invoked from network); 25 May 2006 08:10:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO autolearn=ham version=3.1.1 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 25 May 2006 08:10:53 -0000 Received: (qmail 31196 invoked from network); 25 May 2006 08:10:47 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 25 May 2006 08:10:47 -0000 Received: (qmail 431 invoked by alias); 25 May 2006 08:10:44 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 22458 Received: (qmail 417 invoked from network); 25 May 2006 08:10:43 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 25 May 2006 08:10:43 -0000 Received: (qmail 30927 invoked from network); 25 May 2006 08:10:43 -0000 Received: from dsl-63-249-88-2.cruzio.com (HELO dot.blorf.net) (63.249.88.2) by a.mx.sunsite.dk with SMTP; 25 May 2006 08:10:42 -0000 Received: by dot.blorf.net (Postfix, from userid 1000) id 816611320C; Thu, 25 May 2006 01:10:40 -0700 (PDT) Date: Thu, 25 May 2006 01:10:40 -0700 From: Wayne Davison To: Hideki ONO Cc: zsh-workers@sunsite.dk Subject: Re: PATCH: _ls Message-ID: <20060525081040.GA569@blorf.net> References: <20060523171440.GE21617@blorf.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11+cvs20060403 On Wed, May 24, 2006 at 11:15:47AM +0900, Hideki ONO wrote: > I fixed to use _pick_variant even on *bsd. > How about this one? That looks quite good to me. I tested it a bit, and the new code seems to be working as expected, so I checked it in. Thanks! While I was testing it, I discovered that the completion system is not completing the options to gnu ls correctly, which appears to be a bug: Several options get lost, including --format, -1, -x, and --color (I did not do an exhaustive search to know exactly how many). If I get rid of the rule defining -F, many of these missing options come back (though not --color). Very strange, but totally unrelated to the just-committed changes. ..wayne..