From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: complist with long display lines
Date: Thu, 10 Aug 2006 10:27:10 +0100 [thread overview]
Message-ID: <200608100927.k7A9RA9d019876@news01.csr.com> (raw)
In-Reply-To: <060810010102.ZM24015@torch.brasslantern.com>
Bart Schaefer wrote:
> How did you ever track this down?
That's three evenings which will never come again.
Once I'd found that array indexing for mgtab was off, which took a
certain amount of digging since it's referenced in some odd ways, it
wasn't so hard to find out how the limits were being set and how the
assumption in the line limit was being violated.
As I indicated, whether the assumption is present at all and only the
places where I've applied the fix is another matter to be determined...
> It may be worthwhile (or at least satisfying to paranoid types) to add
> the following patch, which I've had sitting around uncommitted because
> it failed to resolve the addressing issues that you seem to finally
> have identified. This patch prevents the infinite loop alluded to in
> 21842, by catching cases where an array index starts out negative and
> decrements from there. It might be unnecessary now, but:
I don't think I've done anything which would prevent this infinite loop.
mcols comes from the global columns which comes from the environment, so
if that's negative there are problems. So I think this would be useful.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
next prev parent reply other threads:[~2006-08-10 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 15:40 Peter Stephenson
2006-08-07 17:19 ` Bart Schaefer
2006-08-07 21:56 ` DervishD
2006-08-09 22:04 ` Peter Stephenson
2006-08-10 8:01 ` Bart Schaefer
2006-08-10 9:27 ` Peter Stephenson [this message]
2006-08-10 16:22 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608100927.k7A9RA9d019876@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).