From: Peter Stephenson <pws@csr.com>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: Infinite loop in compprintfmt() (complist.c rev 1.91)
Date: Mon, 14 Aug 2006 13:52:09 +0100 [thread overview]
Message-ID: <20060814135209.08fc27c9.pws@csr.com> (raw)
In-Reply-To: <060813214800.ZM6506@torch.brasslantern.com>
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Here's a gdb walk-through -- note we return to line 896 (really the loop
> at 892) without ever incrementing the loop variable.
Yes, I missed the dopr==0 branch when I moved the increment into the point
where we're possibly printing more than one byte.
Index: Src/Zle/complist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/complist.c,v
retrieving revision 1.91
diff -u -r1.91 complist.c
--- Src/Zle/complist.c 11 Aug 2006 21:30:38 -0000 1.91
+++ Src/Zle/complist.c 14 Aug 2006 12:50:29 -0000
@@ -1069,6 +1069,8 @@
return mlprinted;
}
}
+ else
+ p += len;
}
}
if (dopr) {
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
prev parent reply other threads:[~2006-08-14 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-14 4:48 Bart Schaefer
2006-08-14 12:52 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060814135209.08fc27c9.pws@csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).