zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: _all_matches moves cursor
Date: Fri, 06 Oct 2006 17:46:28 +0100	[thread overview]
Message-ID: <200610061646.k96GkSW8003626@news01.csr.com> (raw)
In-Reply-To: <200610061003.k96A3RQh019503@news01.csr.com>

(Moved to zsh-workers.)

Peter Stephenson wrote:
> I've read it more carefully and I think there's simply a bug in the
> calculation at this point.

Aaarggh! No there isn't, add is already in t.  The patch simply moved
the end of output too far to the left, avoiding the problem.

I'm fed up with this, but given the propensity to abbreviate in the
middle of the line, I think simply omitting the initial space would do.
Nothing else works for reasons I can't fathom.

Index: Src/Zle/compresult.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compresult.c,v
retrieving revision 1.66
diff -u -r1.66 compresult.c
--- Src/Zle/compresult.c	6 Oct 2006 10:07:38 -0000	1.66
+++ Src/Zle/compresult.c	6 Oct 2006 16:43:18 -0000
@@ -2126,7 +2126,7 @@
 		if (add)
 		    strcat(buf, " ");
 		strcat(buf, m->str);
-		len -= t + add;
+		len -= t;
 		add = 1;
 	    } else {
 		if (len > add + 2) {
@@ -2134,7 +2134,7 @@
 			strcat(buf, " ");
 		    strncat(buf, m->str, len);
 		}
-		strcat(buf, " ...");
+		strcat(buf, "...");
 		break;
 	    }
 	}

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php


           reply	other threads:[~2006-10-06 16:46 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200610061003.k96A3RQh019503@news01.csr.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610061646.k96GkSW8003626@news01.csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).