zsh-workers
 help / color / mirror / code / Atom feed
From: Clint Adams <schizo@debian.org>
To: zsh-workers@sunsite.dk
Cc: Ryo IGARASHI <rigarash@gmail.com>, 377765-forwarded@bugs.debian.org
Subject: Re: Bug#377765: zsh: completion of configure script does not handle underscore properly
Date: Sat, 7 Oct 2006 05:53:01 -0400	[thread overview]
Message-ID: <20061007095301.GA2210@scowler.net> (raw)
In-Reply-To: <20060711070135.40826124047@star.phys.s.u-tokyo.ac.jp>

On Tue, Jul 11, 2006 at 04:01:35PM +0900, Ryo IGARASHI wrote:
> When you make a configure option with underscore, completion returns
> without underscore. For example, if you have options like:
> 
>  $ ./configure --help
>  ...snip...
>  Optional Packages:
>    --with-under_score=DIR path to under_score library
>  ...snip...
> 
> Then you get the following completion output:
> 
>  $ ./configure [TAB]
>  --with-underscore   --without-underscore
> 
> I attached the test case for this bug.

This appears to fix that immediate problem.  Is there any downside to
allowing underscores?

Not committing.

Index: Completion/Base/Utility/_arguments
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Base/Utility/_arguments,v
retrieving revision 1.17
diff -u -r1.17 _arguments
--- Completion/Base/Utility/_arguments	27 Sep 2006 16:53:59 -0000	1.17
+++ Completion/Base/Utility/_arguments	7 Oct 2006 09:50:40 -0000
@@ -165,7 +165,7 @@
                     "${${opt%%\=*}//[^a-zA-Z0-9-]}=:${(L)${opt%\]}#*\=}: " )
           done
         else
-          tmpo=("${(@)${(@)tmpo%%\=*}//[^a-z0-9-]}")
+          tmpo=("${(@)${(@)tmpo%%\=*}//[^a-z0-9_-]}")
 
 	  cache=( "$cache[@]" "${(@)^tmpo}=${dir}${descr}" )
         fi


       reply	other threads:[~2006-10-07  9:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060711070135.40826124047@star.phys.s.u-tokyo.ac.jp>
2006-10-07  9:53 ` Clint Adams [this message]
2007-03-29  1:20   ` Ryo IGARASHI
2007-12-13 19:09     ` Clint Adams
2007-12-13 20:56       ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061007095301.GA2210@scowler.net \
    --to=schizo@debian.org \
    --cc=377765-forwarded@bugs.debian.org \
    --cc=rigarash@gmail.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).