zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: fg call in function: bug?
Date: Mon, 6 Nov 2006 12:22:15 +0000	[thread overview]
Message-ID: <20061106122215.5163e217.pws@csr.com> (raw)
In-Reply-To: <17393e3e0611031639g31c94488m7605a5841a3c9e25@mail.gmail.com>

"Matt Wozniski" <mjw452@drexel.edu> wrote:
> If I run 'fg %n' with a job number that doesn't exist, it has
> different (and worse) effects in a function than at a prompt.  (Sorry
> if this has been fixed in CVS... Ubuntu Dapper doesn't have a package
> past 4.2.5 yet.. ;) )

I think this is most easily fixed by telling the code to ignore jobs in the
current shell for the purpose of job control; they're fictions to make
special effects easier.  I can't offhand see this is going to cause any
problems, but we'll just have to see.  Certainly you wouldn't expect to
be able to do job control on them.

Index: Src/exec.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/exec.c,v
retrieving revision 1.104
diff -u -r1.104 exec.c
--- Src/exec.c	17 Sep 2006 19:28:46 -0000	1.104
+++ Src/exec.c	6 Nov 2006 12:18:31 -0000
@@ -2265,7 +2265,7 @@
 	/* This is a current shell procedure that didn't need to fork.    *
 	 * This includes current shell procedures that are being exec'ed, *
 	 * as well as null execs.                                         */
-	jobtab[thisjob].stat |= STAT_CURSH;
+	jobtab[thisjob].stat |= STAT_CURSH|STAT_NOPRINT;
     } else {
 	/* This is an exec (real or fake) for an external command.    *
 	 * Note that any form of exec means that the subshell is fake *



To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php


      parent reply	other threads:[~2006-11-06 12:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-04  0:39 Matt Wozniski
2006-11-04  1:15 ` Matt Wozniski
2006-11-04  2:50   ` Bart Schaefer
     [not found]     ` <17393e3e0611031856v21f9bc19k9a9f25ff5ef002ba@mail.gmail.com>
2006-11-04  2:57       ` Matt Wozniski
2006-11-04 18:10         ` Bart Schaefer
2006-11-06 12:27   ` Peter Stephenson
2006-11-06 12:22 ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061106122215.5163e217.pws@csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).