zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: bug : _make and special parameters
Date: Thu, 09 Nov 2006 10:50:25 +0000	[thread overview]
Message-ID: <200611091050.kA9AoPSq022667@news01.csr.com> (raw)
In-Reply-To: <20061108194249.GA8389@localhost.localdomain>

> I downloaded qiv sources, went in the right directory, typed "make" and
> <TAB>
> 
> I got the error :  (eval):1: read-only variable: CURSOR
> 
> This is because in _make, Makefile lines are parsed to find for
> variables declarations, and then assigned with :
> eval $var=\$val
> 
> But in qiv Makefile, there is the line :
> CURSOR = 84
> and CURSOR is a parameter special in zsh.
> 
> That problem could happen with any special parameters.
> 
> I found a solution by adding the line
> typeset -h $var
> just before eval

I think you've got the right sort of idea.  However, parseMakefile can
run recursively, because it handles include declarations, so the
variables need to go in the top-level namespace.  There's no easy way of
ensuring this, unfortunately, since there's no way of making the
parameter local (necessary since the global parameter is special) but at
a particular level.  So I'll commit your patch for now.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php


  reply	other threads:[~2006-11-09 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-08 19:42 arno.
2006-11-09 10:50 ` Peter Stephenson [this message]
2006-11-10  9:56   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611091050.kA9AoPSq022667@news01.csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).