zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: NULL-Pointer dereference in complist.c
Date: Fri, 02 Feb 2007 23:50:16 +0000	[thread overview]
Message-ID: <200702022350.l12NoGr0004043@pwslaptop.csr.com> (raw)
In-Reply-To: Message from Felix Eckhofer <felix@tribut.de>  of "Fri, 02 Feb 2007 23:45:11 +0100." <200702022345.29023.felix@tribut.de>

Felix Eckhofer wrote:
> However, I was quickly able to reproduce a segfault on my machine
> (Ubuntu 6.10, zsh 4.3.2-13ubuntu1, x86_64). It happens, because at
> complist.c:1848 s =3D=3D NULL. I wasn't able to understand completely what
> happens but the attached patch works for me and seems reasonable.
> 
> Unfortunately, CVS seems down for the moment so I couldn't check whether
> this is already fixed in HEAD. If it is, ignore me :)

There's no corresponding fix yet, but the code is pretty much the same at
that point, so, although I couldn't get it to happen with a short play,
I applied your patch, which certainly looks unproblematic.  Thanks.

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


      reply	other threads:[~2007-02-02 23:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <felix@tribut.de>
2007-02-02 22:45 ` Felix Eckhofer
2007-02-02 23:50   ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702022350.l12NoGr0004043@pwslaptop.csr.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).