zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: PATCH: newline display problem in completion lists
Date: Tue, 13 Feb 2007 21:50:05 +0000	[thread overview]
Message-ID: <200702132150.l1DLo5pn006613@pwslaptop.csr.com> (raw)

Good news on the problem where ^xh goes down too many lines.

You can see it quite easily:

_frob() { compadd -UX $'foo\nand\nbar' -n ''; }
compdef _frob frob
frob ^D

It turns out just to be a simple typo.  I'm extremely relieved.

Index: Src/Zle/zle_tricky.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_tricky.c,v
retrieving revision 1.83
diff -u -r1.83 zle_tricky.c
--- Src/Zle/zle_tricky.c	26 Jan 2007 19:11:48 -0000	1.83
+++ Src/Zle/zle_tricky.c	13 Feb 2007 21:47:40 -0000
@@ -2247,7 +2247,8 @@
 		}
 		l += 1 + ((cc - 1) / columns);
 		cc = 0;
-		putc('\n', shout);
+		if (dopr)
+		    putc('\n', shout);
 		p++;
 	    } else {
 		convchar_t cchar;

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


                 reply	other threads:[~2007-02-13 21:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702132150.l1DLo5pn006613@pwslaptop.csr.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).