zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: "Ismail Dönmez" <ismail@pardus.org.tr>, zsh-workers@sunsite.dk
Subject: Re: Locale related problem with zshrc parsing
Date: Thu, 15 Mar 2007 14:43:51 +0000	[thread overview]
Message-ID: <20070315144351.c3edeb14.pws@csr.com> (raw)
In-Reply-To: <200703151557.59720.ismail@pardus.org.tr>

Ismail Dönmez <ismail@pardus.org.tr> wrote:
> zsh seems to be affected by infamous Turkish locale (LC_ALL=tr_TR.UTF-8)
> problem. In Turkish lowercase of "I" is not i but its ı (i-dotless). And
> this seems to affect zsh too :
> 
> [~]> zsh --version
> zsh 4.3.2-dev-1 (i686-pc-linux-gnu)
> 
> [~]> setopt SHARE_HISTORY
> setopt: no such option: SHARE_HISTORY

Thanks, I've fixed this occurrence but you may see similar things
occurring from other places in the code.

Index: Src/options.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/options.c,v
retrieving revision 1.34
diff -u -r1.34 options.c
--- Src/options.c	6 Feb 2007 21:47:55 -0000	1.34
+++ Src/options.c	15 Mar 2007 14:32:42 -0000
@@ -603,7 +603,14 @@
 	if (*t == '_')
 	    chuck(t);
 	else {
-	    *t = tulower(*t);
+	    /*
+	     * Some locales (in particular tr_TR.UTF-8) may
+	     * have non-standard mappings of ASCII characters,
+	     * so be careful.  Option names must be ASCII so
+	     * we don't need to be too clever.
+	     */
+	    if (*t >= 'A' && *t <= 'Z')
+		*t = (*t - 'A') + 'a';
 	    t++;
 	}
 


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php

To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview


  reply	other threads:[~2007-03-15 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-15 13:57 Ismail Dönmez
2007-03-15 14:43 ` Peter Stephenson [this message]
2007-03-15 15:08   ` Ismail Dönmez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070315144351.c3edeb14.pws@csr.com \
    --to=pws@csr.com \
    --cc=ismail@pardus.org.tr \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).