zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@sunsite.dk
Subject: Re: Updates to zsh-4_2-patches branch
Date: Tue, 27 Mar 2007 21:47:53 +0100	[thread overview]
Message-ID: <200703272047.l2RKlrX0005081@pwslaptop.csr.com> (raw)
In-Reply-To: Message from Paul Ackersviller <pda@sdf.lonestar.org>  of "Tue, 27 Mar 2007 20:20:48 -0000." <20070327202048.GA4134@sverige>

Paul Ackersviller wrote:
> I promised to do this months ago, but didn't get far over the course
> of the winter...  Excuses aside, I've been hard at it for the past
> week or two, and have gotten up to about the middle of last year in
> merging trunk changes onto the branch.

Thanks for the work, it's very useful.

> How comprehensive is the test suite, and are there any major gotchas?

The test suite is good at stuff related to scripting and syntax,
moderately good but rather incomplete at the low levels of completion
and line editing, and poor at things which are only testable
interactively like job control.

> One area I could use help or at least guidance on is files in Src/Zle/.
> I've merged in only a few changes there, when it appeared to be
> non-multibyte-related, but is it better to try leaving that completely
> alone?  I fear a few multibyte changes that don't belong mat have crept
> in, but I'll see how testing goes.

Zle has changed so much that it might well be better to leave anything
alone that isn't obviously a standalone fix for a specific problem
that applies cleanly.  We've made various tweaks to simplify interfaces
both internally and to related parts of the main shell such as quoting
to make adding multibyte support easier; these aren't generally
bug fixes and don't need applying.

> In terms of documenting what I've done, is there any value in sending
> all the change numbers to this list?  There will be very many, so I'm
> thinking those numbers would better go into the change comments for the
> individual cvs revisions.

It would be fine if they just appeared in the ChangeLog on the branch.

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


  reply	other threads:[~2007-03-27 23:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <pda@sdf.lonestar.org>
2007-03-27 20:20 ` Paul Ackersviller
2007-03-27 20:47   ` Peter Stephenson [this message]
2007-10-30  2:01   ` Geoff Wing
2007-11-02  4:03     ` Paul Ackersviller
2007-11-05  1:41       ` C03 test failure on " Paul Ackersviller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703272047.l2RKlrX0005081@pwslaptop.csr.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).