* Re: Bug#416441: Patch [not found] <200703311841.27521.debian@ejohansson.se> @ 2007-03-31 17:01 ` Clint Adams 2007-03-31 18:30 ` Bart Schaefer 0 siblings, 1 reply; 3+ messages in thread From: Clint Adams @ 2007-03-31 17:01 UTC (permalink / raw) To: zsh-workers; +Cc: Erik Johansson, 416441 On Sat, Mar 31, 2007 at 06:41:27PM +0200, Erik Johansson wrote: > The attached patch fixes the problem for me. Thanks. > --- _module.ORG 2007-03-31 17:47:42.000000000 +0200 > +++ _module 2007-03-31 17:55:08.000000000 +0200 > @@ -83,7 +83,7 @@ > # Fills the available modules cache > _module_available_modules() > { > - if (( [[ -n "$MODULEPATH" ]] && [[ ${+_available_modules} -eq 0 ]] )); > + if (( [[ -n $MODULEPATH ]] && [[ ${+_available_modules} -eq 0 ]] )); > then > _available_modules=($(find ${(e)=MODULEPATH//:/ } -xtype f -print 2>/dev/null | grep -v \.version | sed -e 's,\('${${(e)=MODULEPATH//:/\/\\\|}%\\\|}'\),,g' -e 's,^/*,,g')) > fi Why would this break zcompile? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug#416441: Patch 2007-03-31 17:01 ` Bug#416441: Patch Clint Adams @ 2007-03-31 18:30 ` Bart Schaefer 2007-03-31 19:01 ` Clint Adams 0 siblings, 1 reply; 3+ messages in thread From: Bart Schaefer @ 2007-03-31 18:30 UTC (permalink / raw) To: Clint Adams, zsh-workers; +Cc: Erik Johansson, 416441 On Mar 31, 1:01pm, Clint Adams wrote: } Subject: Re: Bug#416441: Patch } } On Sat, Mar 31, 2007 at 06:41:27PM +0200, Erik Johansson wrote: } > The attached patch fixes the problem for me. } } Thanks. } } > --- _module.ORG 2007-03-31 17:47:42.000000000 +0200 } > +++ _module 2007-03-31 17:55:08.000000000 +0200 } > @@ -83,7 +83,7 @@ } > # Fills the available modules cache } > _module_available_modules() } > { } > - if (( [[ -n "$MODULEPATH" ]] && [[ ${+_available_modules} -eq 0 ]] )); } > + if (( [[ -n $MODULEPATH ]] && [[ ${+_available_modules} -eq 0 ]] )); } > then } > _available_modules=($(find ${(e)=MODULEPATH//:/ } -xtype f -print 2>/dev/null | grep -v \.version | sed -e 's,\('${${(e)=MODULEPATH//:/\/\\\|}%\\\|}'\),,g' -e 's,^/*,,g')) } > fi } } Why would this break zcompile? What's up with the double parens? if (( ... this is parsed as a math expression ... )) I don't know why zcompile chokes on that when the regular interpreter does not, but it almost certainly ought to be a syntax error long before the unmatched double-quote error that zcompile coughs up. if [[ -n $MODULEPATH ]] && [[ ${+_available_modules} -eq 0 ]] without the excess parens and trailing semicolon, ought to be sufficient. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug#416441: Patch 2007-03-31 18:30 ` Bart Schaefer @ 2007-03-31 19:01 ` Clint Adams 0 siblings, 0 replies; 3+ messages in thread From: Clint Adams @ 2007-03-31 19:01 UTC (permalink / raw) To: zsh-workers > What's up with the double parens? That's a good question too. Index: Completion/Unix/Command/_module =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_module,v retrieving revision 1.4 diff -u -r1.4 _module --- Completion/Unix/Command/_module 31 Mar 2007 17:05:28 -0000 1.4 +++ Completion/Unix/Command/_module 31 Mar 2007 19:00:55 -0000 @@ -83,7 +83,7 @@ # Fills the available modules cache _module_available_modules() { - if (( [[ -n $MODULEPATH ]] && [[ ${+_available_modules} -eq 0 ]] )); + if [[ -n $MODULEPATH ]] && [[ ${+_available_modules} -eq 0 ]] then _available_modules=($(find ${(e)=MODULEPATH//:/ } -xtype f -print 2>/dev/null | grep -v \.version | sed -e 's,\('${${(e)=MODULEPATH//:/\/\\\|}%\\\|}'\),,g' -e 's,^/*,,g')) fi ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-01 0:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200703311841.27521.debian@ejohansson.se>
2007-03-31 17:01 ` Bug#416441: Patch Clint Adams
2007-03-31 18:30 ` Bart Schaefer
2007-03-31 19:01 ` Clint Adams
Code repositories for project(s) associated with this public inbox https://git.vuxu.org/mirror/zsh/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).