zsh-workers
 help / color / mirror / code / Atom feed
From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: zsh-workers@sunsite.dk
Subject: 4.3.4 HEAD and iconv
Date: Wed, 25 Apr 2007 18:17:02 -0700	[thread overview]
Message-ID: <20070426011702.GA86823@redoubt.spodhuis.org> (raw)

Hi,

If I get the current HEAD source then it won't build for me by default,
as I didn't let it know where iconv was and there's a point in the code
which assumes that if you HAVE_NL_LANGINFO and CODESET then you can use
a variable, count, which only exists if you HAVE_ICONV.

No idea whether or not this is a logically correct fix, but it does let
the code compile and run.

--- zsh-head/Src/utils.c        Tue Apr 17 04:59:38 2007
+++ zsh/Src/utils.c     Wed Apr 25 17:35:12 2007
@@ -4569,10 +4569,12 @@
     int count;
 #else
     unsigned int wval;
-# if defined(HAVE_NL_LANGINFO) && defined(CODESET) && defined(HAVE_ICONV)
+# if defined(HAVE_NL_LANGINFO) && defined(CODESET)
+#  if defined(HAVE_ICONV)
     iconv_t cd;
     char inbuf[4];
     size_t inbytes, outbytes;
+#  endif
     size_t count;
 # endif
 #endif


             reply	other threads:[~2007-04-26  1:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26  1:17 Phil Pennock [this message]
2007-04-26  9:28 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070426011702.GA86823@redoubt.spodhuis.org \
    --to=zsh-workers+phil.pennock@spodhuis.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).