From: Peter Stephenson <pws@csr.com>
To: Zsh Hackers <zsh-workers@sunsite.dk>
Subject: Re: PATCH: and query for malloc(0).
Date: Mon, 30 Apr 2007 10:22:41 +0100 [thread overview]
Message-ID: <200704300922.l3U9MfJj032732@news01.csr.com> (raw)
In-Reply-To: <20070430032948.GA2612@primenet.com.au>
Geoff Wing wrote:
> On Saturday 2007-04-28 07:36 +1000, Peter Stephenson output:
> :Playing with POSIX regexes, I found some errors coming from zsh's memory
> :allocation with debugging on. These turned out to resolve to some
> :malloc()s and free()s for zero length and the following oddity in
> :malloc():
> : /* some systems want malloc to return the highest valid address plus one
> : if it is called with an argument of zero */
> : if (!size)
> : return (MALLOC_RET_T) m_high;
>...
> Given the above, I guess the patch is a reasonable fix.
Thanks, I think I'll commit it and see what happens; under most
circumstances that will be very little.
> We are not actually calling malloc(0) in-house, are we?
No, that should be trapped up above in zalloc(), etc. I've only seen
the problem when linked with a C library function that's calling
malloc(0).
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview
prev parent reply other threads:[~2007-04-30 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 21:35 Peter Stephenson
2007-04-30 3:29 ` Geoff Wing
2007-04-30 9:22 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704300922.l3U9MfJj032732@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).