zsh-workers
 help / color / mirror / code / Atom feed
From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: zsh-workers@sunsite.dk
Subject: Re: [PATCH] exec compatibility
Date: Mon, 7 May 2007 00:32:53 -0700	[thread overview]
Message-ID: <20070507073253.GA3250@redoubt.spodhuis.org> (raw)
In-Reply-To: <070506225634.ZM9288@torch.brasslantern.com>

On 2007-05-06 at 22:56 -0700, Bart Schaefer wrote:
> One thing that rather annoys me about all this is that
> 
> 	zsh% - exec sh
> and
> 	zsh% exec - sh
> 
> seem no longer to be equivalent.  Am I wrong about that?

Uhm, I think so.  Test results below, and I didn't change anything that
would affect the prefix processing of - as the first modifier and I was
very careful to ensure that a single - would be left unmolested, with
this:
  while (next && *next == '-' && strlen(next) >= 2) {
bit in the options processing for the BINF_EXEC case.  That code's still
there in pws's improved patch.  So - always sets BINF_DASH which will be
handled as before.

Perhaps with a commit an extra comment should be added just above that
line, noting that - needs to be carefully left alone as it's a
precommand modifier in its own right.  I really shouldn't have left that
unremarked upon in the code.


Nuked ~/dbg/bin/zsh* and ~/dbg/lib/zsh
Took cvs HEAD and patched with pws's patch.  Built and installed, with
--prefix=$HOME/dbg set.

Below:
 * Double-nesting of ./dbg/bin/zsh to protect against an accidental
   extra EOF or similar mishap
 * leading [N] is SHLVL, so "$ [2]" means there's a Ctrl-D in there


-pdp@redoubt.spodhuis:p0[0:20](1032)~% ./dbg/bin/zsh
[2]-pdp@redoubt.spodhuis:p0[0:20](1025)~% ./dbg/bin/zsh
[3]-pdp@redoubt.spodhuis:p0[0:20](1001)~% exec -l sh
$ echo $0
-sh
$ [2]-pdp@redoubt.spodhuis:p0[0:21](1026)~% ./dbg/bin/zsh
[3]-pdp@redoubt.spodhuis:p0[0:21](1001)~% - exec sh
$ echo $0
-sh
$ [2]-pdp@redoubt.spodhuis:p0[0:21](1027)~% ./dbg/bin/zsh
[3]-pdp@redoubt.spodhuis:p0[0:21](1001)~% exec - sh
$ echo $0
-sh
$ [2]-pdp@redoubt.spodhuis:p0[0:21](1028)~% 


  reply	other threads:[~2007-05-07  7:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-01  0:26 Phil Pennock
2007-05-04 12:00 ` Peter Stephenson
2007-05-07  5:56   ` Bart Schaefer
2007-05-07  7:32     ` Phil Pennock [this message]
2007-05-08 10:09       ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070507073253.GA3250@redoubt.spodhuis.org \
    --to=zsh-workers+phil.pennock@spodhuis.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).