zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: Zsh-Workers <zsh-workers@sunsite.dk>
Subject: Re: bindkey <whatever> history-beginning-search-backwards; echo $widgts = crash
Date: Tue, 22 May 2007 10:29:54 +0100	[thread overview]
Message-ID: <20070522102954.409da21c@news01.csr.com> (raw)
In-Reply-To: <20070522015923.GA12001@redoubt.spodhuis.org>

On Mon, 21 May 2007 18:59:23 -0700
Phil Pennock <zsh-workers+phil.pennock@spodhuis.org> wrote:
> On 2007-05-21 at 18:46 -0700, Phil Pennock wrote:
> > This is a bug when there is no widget with the supplied name; the
> > value for the type can't be calculated.  The code which loops over
> > the widgets doesn't notice that the widget doesn't really exist and
> > the code which produces a stringification doesn't handle it.
> 
> Is it better for the $widgets associative array to pretend that such a
> key doesn't exist, or to acknowledge that it does exist with undefined
> value?

I think the latter.  If the user is convinced the widget should exist
and has tried to bind something to it the shell should show as much.
The juice stains the lips, the stain acts as a warning (as it were).
(No, that doesn't really make sense.)

I've committed that patch.  Thanks.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php

To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview


  reply	other threads:[~2007-05-22  9:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21 20:21 Maddi Kopfermann
2007-05-22  1:46 ` Phil Pennock
2007-05-22  1:59   ` Phil Pennock
2007-05-22  9:29     ` Peter Stephenson [this message]
2007-05-22  3:32   ` Maddi Kopfermann
2007-05-22  5:37     ` Bart Schaefer
2007-05-22  9:27       ` Maddi Kopfermann
2007-05-22  5:55     ` Phil Pennock
2007-05-22 13:32       ` Maddi Kopfermann
  -- strict thread matches above, loose matches on Subject: below --
2007-05-15  9:59 PATCH: reverse matching (tentative) Peter Stephenson
2007-05-15 21:06 ` Matt Wozniski
2007-05-21  9:49   ` Peter Stephenson
2007-05-21 18:42     ` bindkey <whatever> history-beginning-search-backwards; echo $widgts = crash Maddi Kopfermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070522102954.409da21c@news01.csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).