From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13532 invoked from network); 28 May 2007 12:31:55 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.0 (2007-05-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=no version=3.2.0 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 28 May 2007 12:31:55 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 1437 invoked from network); 28 May 2007 12:31:48 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 28 May 2007 12:31:48 -0000 Received: (qmail 27285 invoked by alias); 28 May 2007 12:31:45 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 23478 Received: (qmail 27275 invoked from network); 28 May 2007 12:31:44 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 28 May 2007 12:31:44 -0000 Received: (qmail 1159 invoked from network); 28 May 2007 12:31:44 -0000 Received: from mtaout03-winn.ispmail.ntl.com (81.103.221.49) by a.mx.sunsite.dk with SMTP; 28 May 2007 12:31:41 -0000 Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout03-winn.ispmail.ntl.com with ESMTP id <20070528123140.HVQF13.mtaout03-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com>; Mon, 28 May 2007 13:31:40 +0100 Received: from pwslaptop.csr.com ([81.107.45.67]) by aamtaout03-winn.ispmail.ntl.com with ESMTP id <20070528123139.JJML26699.aamtaout03-winn.ispmail.ntl.com@pwslaptop.csr.com>; Mon, 28 May 2007 13:31:39 +0100 Received: from pwslaptop.csr.com (pwslaptop.csr.com [127.0.0.1]) by pwslaptop.csr.com (8.13.8/8.13.7) with ESMTP id l4SCTMuI003623; Mon, 28 May 2007 13:29:23 +0100 Message-Id: <200705281229.l4SCTMuI003623@pwslaptop.csr.com> From: Peter Stephenson To: zsh-workers@sunsite.dk, =?iso-8859-1?Q?J=F6rg?= Sommer , 426161-forwarded@bugs.debian.org Subject: Re: Bug#426161: zsh: crashes in reverse_menu In-Reply-To: Message from Clint Adams of "Sat, 26 May 2007 22:50:23 EDT." <20070527025023.GA19806@scowler.net> Date: Mon, 28 May 2007 13:29:22 +0100 Clint Adams wrote: > On Sat, May 26, 2007 at 10:54:26PM +0200, Jörg Sommer wrote: > > Hi, > > > > after typing “vared CF” I've called “reverse-menu-complete” with M-x and > > zsh crashes. This also happens in zsh-beta 4.3.4-dev-0+20070516-1 and is > > not #416970. > > This is because reverse_menu() is trying to dereference minfo.group > which is NULL. I suspect that means we shouldn't do that. Index: Src/Zle/compresult.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Zle/compresult.c,v retrieving revision 1.70 diff -u -r1.70 compresult.c --- Src/Zle/compresult.c 30 Oct 2006 14:13:39 -0000 1.70 +++ Src/Zle/compresult.c 28 May 2007 12:29:55 -0000 @@ -1227,6 +1227,9 @@ { int was_meta; + if (minfo.cur == NULL) + return 1; + do { if (minfo.cur == (minfo.group)->matches) { do { -- Peter Stephenson Web page now at http://homepage.ntlworld.com/p.w.stephenson/