From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: PATCH: test output to terminal dehackery
Date: Wed, 30 May 2007 10:49:15 +0100 [thread overview]
Message-ID: <200705300949.l4U9nFw4009642@news01.csr.com> (raw)
In-Reply-To: <070529202902.ZM13215@torch.brasslantern.com>
Bart Schaefer wrote:
> On May 29, 3:43pm, Peter Stephenson wrote:
> }
> } We now have the technology to open a file descriptor for test input and
> } terminal output without using up one of the standard shell ones.
> } The {fd}<redir> syntax opens up an unused fd from 10 on.
>
> Hrm. I'm ambivalent about this patch. The {fd}< syntax is one of the
> things that gets tested for correctness quite a bit later on. If it
> doesn't work properly here, could the whole test suite fail?
>
> That is, I'm wondering if the implementation of the test suite should
> restrict itself to the most basic shell operations possible and only
> the tests themselves employ extended functionality.
I don't really believe in the division between basic and extended
functionality, except as regards add-ons; if the shell's broken it needs
fixing. You're correct that the new syntax isn't used as much so it's
more likely it would get broken without anyone noticing. I don't see
any implication beyond needing to fix that before running other
tests, however; that can in principle happen with anything.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview
next prev parent reply other threads:[~2007-05-30 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 14:43 Peter Stephenson
2007-05-29 15:01 ` Stephane Chazelas
2007-05-30 3:29 ` Bart Schaefer
2007-05-30 9:49 ` Peter Stephenson [this message]
2007-05-30 11:03 ` Bart Schaefer
2007-05-30 11:17 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705300949.l4U9nFw4009642@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).